From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: COGONI Guillaume <cogoni.guillaume@gmail.com>,
avarab@gmail.com, Matthieu.Moy@univ-lyon1.fr,
git.jonathan.bressat@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] contrib/vscode/: debugging with VS Code and gdb
Date: Wed, 06 Apr 2022 13:23:25 -0700 [thread overview]
Message-ID: <xmqqbkxex8oy.fsf@gitster.g> (raw)
In-Reply-To: <378c5790-f587-4e26-87be-8f856974e5ca@github.com> (Derrick Stolee's message of "Wed, 6 Apr 2022 14:03:12 -0400")
Derrick Stolee <derrickstolee@github.com> writes:
>
>> Signed-off-by: COGONI Guillaume <cogoni.guillaume@gmail.com>
>> Co-authored-by: BRESSAT Jonathan <git.jonathan.bressat@gmail.com>
>> Helped-by: Matthieu Moy <Matthieu.Moy@univ-lyon1.fr>
>> Helped-by: Derrick Stolee <derrickstolee@github.com>
>
> Here, you probably want to flip the order here (Helped-by, then
> Co-authored-by, then Signed-off-by). You probably also want the
> sign-off of your co-author, too.
>
> The sign-off should be the last thing in the message, because
> the previous lines are covered by that sign-off.
Yup. It would record the order of events that lead to this exact
patch, which is what we want to capture. With help by these people,
together with the co-author(s), the patch was written and author(s)
signed-off before it was sent out to the list.
> ...
> And this is the necessary fix.
>
> Thanks for working on this!
Indeed. And thanks for a helpful review.
next prev parent reply other threads:[~2022-04-06 21:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 8:16 contrib/vscode/: debugging with vscode and gdb Jonathan Bressat
2022-03-25 13:19 ` Derrick Stolee
[not found] ` <2a7eecb4a0b247ef8f855f1c4fb5d510@SAMBXP02.univ-lyon1.fr>
2022-03-25 18:27 ` Matthieu Moy
2022-03-25 19:01 ` Derrick Stolee
2022-03-26 14:11 ` Jonathan Bressat
2022-04-03 20:18 ` Guillaume Cogoni
[not found] ` <7b139f2c480e4ebc8dc6615b44cd5f24@SAMBXP02.univ-lyon1.fr>
2022-04-05 9:43 ` Matthieu Moy
2022-04-05 22:45 ` [PATCH V1 0/1] contrib/vscode/: debugging with VS Code " COGONI Guillaume
2022-04-05 22:45 ` [PATCH V1 1/1] " COGONI Guillaume
2022-04-06 8:47 ` Ævar Arnfjörð Bjarmason
2022-04-06 11:59 ` Matthieu Moy
2022-04-06 13:35 ` Matthieu Moy
2022-04-06 15:18 ` [PATCH v2 0/1] " COGONI Guillaume
2022-04-06 15:18 ` [PATCH v2 1/1] " COGONI Guillaume
2022-04-06 18:03 ` Derrick Stolee
2022-04-06 20:23 ` Junio C Hamano [this message]
2022-04-06 23:39 ` [PATCH v3 0/1] " COGONI Guillaume
2022-04-06 23:39 ` [PATCH v3 1/1] " COGONI Guillaume
2022-04-07 11:17 ` Ævar Arnfjörð Bjarmason
2022-04-07 13:09 ` Derrick Stolee
2022-04-07 16:43 ` Junio C Hamano
2022-04-07 20:40 ` [PATCH v4 0/1] " COGONI Guillaume
2022-04-07 20:40 ` [PATCH v4 1/1] " COGONI Guillaume
[not found] ` <66f08cb2e81647e29a080af05d7c867e@SAMBXP02.univ-lyon1.fr>
2022-04-07 8:59 ` [PATCH V1 " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbkxex8oy.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@univ-lyon1.fr \
--cc=avarab@gmail.com \
--cc=cogoni.guillaume@gmail.com \
--cc=derrickstolee@github.com \
--cc=git.jonathan.bressat@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).