From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Lessley Dennington <lessleydennington@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: Bug report - sparse-checkout ignores prefix when run in subdirectories
Date: Wed, 05 Jan 2022 15:29:28 -0800 [thread overview]
Message-ID: <xmqqbl0pg3s7.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BH5woi6KY7OBpnsS-M2EmgLHii9zs8rSwrgcPFkOAvn_A@mail.gmail.com> (Elijah Newren's message of "Wed, 5 Jan 2022 15:19:58 -0800")
Elijah Newren <newren@gmail.com> writes:
> So, should "**.py" go directly into the sparse-checkout file as-is, or
> be translated to "my/current/subdir/**.py" first?
>
> Maybe translating is always fine, or maybe we want to throw an error
> when: (not using cone mode and prefix is non-empty and any patterns
> are provided).
>
> Thoughts?
Perhaps allow things like ":(glob,icase,top)frotz" to be passed and
treating them as pathspec is the most sensible way to go outside the
cone mode? As far as I understand, the cone mode is a strict subset
that is straight-jacketed into "no patterns allowed, just concrete
directory names and nothing else" for simplicity, so it is perfectly
OK for these two to be taking different things.
next prev parent reply other threads:[~2022-01-05 23:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 20:13 Bug report - sparse-checkout ignores prefix when run in subdirectories Lessley Dennington
2022-01-05 22:38 ` Junio C Hamano
2022-01-05 23:19 ` Elijah Newren
2022-01-05 23:29 ` Junio C Hamano [this message]
2022-01-06 0:08 ` Elijah Newren
2022-01-06 0:17 ` Junio C Hamano
2022-01-06 1:08 ` Elijah Newren
2022-01-06 19:25 ` Junio C Hamano
2022-01-27 16:43 ` Derrick Stolee
2022-01-27 17:30 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbl0pg3s7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lessleydennington@gmail.com \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).