From: Junio C Hamano <gitster@pobox.com>
To: Fabian Stelzer <fs@gigacodes.de>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpg-interface: avoid buffer overrun in parse_ssh_output()
Date: Mon, 01 Nov 2021 10:44:57 -0700 [thread overview]
Message-ID: <xmqqbl33db3a.fsf@gitster.g> (raw)
In-Reply-To: <d758381f-064a-1d0a-afab-cb2160ea2eec@gigacodes.de> (Fabian Stelzer's message of "Mon, 1 Nov 2021 09:33:39 +0100")
Fabian Stelzer <fs@gigacodes.de> writes:
> On 30.10.21 19:07, René Scharfe wrote:
>> If the string "key" we found in the output of ssh-keygen happens to be
>> located at the very end of the line, then going four characters further
>> leaves us beyond the end of the string. Explicitly search for the
>> space after "key" to handle a missing one gracefully.
>>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>> ---
>> This code was added after v2.33.0.
>>
>>
>
> Thanks. This is obviously correct.
Thanks, both. Will apply.
next prev parent reply other threads:[~2021-11-01 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 17:04 [PATCH 1/2] gpg-interface: handle missing " with " gracefully in parse_ssh_output() René Scharfe
2021-10-30 17:07 ` [PATCH 2/2] gpg-interface: avoid buffer overrun " René Scharfe
2021-11-01 6:07 ` Junio C Hamano
2021-11-01 8:33 ` Fabian Stelzer
2021-11-01 17:44 ` Junio C Hamano [this message]
2021-11-01 6:08 ` [PATCH 1/2] gpg-interface: handle missing " with " gracefully " Junio C Hamano
2021-11-01 8:40 ` Fabian Stelzer
2021-11-01 18:36 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbl33db3a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).