Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] submodule foreach: replace $path with $sm_path in example
Date: Fri, 31 Jan 2020 12:57:39 -0800	[thread overview]
Message-ID: <xmqqblqj9we4.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200131170843.11130-1-kyle@kyleam.com> (Kyle Meyer's message of "Fri, 31 Jan 2020 12:08:43 -0500")

Kyle Meyer <kyle@kyleam.com> writes:

> f0fd0dc5c5 (submodule foreach: document '$sm_path' instead of '$path',
> 2018-05-08) updated the documentation to advise callers to favor
> $sm_path over the deprecated synonym $path.  However, the example in
> that section still uses $path.  Update it to use $sm_path.
>
> Signed-off-by: Kyle Meyer <kyle@kyleam.com>

Makes sense.  Thanks for a careful reading.  Will apply.

> ---
>  Documentation/git-submodule.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index 5232407f68..218942acd1 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -229,7 +229,7 @@ As an example, the command below will show the path and currently
>  checked out commit for each submodule:
>  +
>  --------------
> -git submodule foreach 'echo $path `git rev-parse HEAD`'
> +git submodule foreach 'echo $sm_path `git rev-parse HEAD`'
>  --------------
>  
>  sync [--recursive] [--] [<path>...]::

      reply	other threads:[~2020-01-31 20:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 17:08 [PATCH] submodule foreach: replace $path with $sm_path in example Kyle Meyer
2020-01-31 20:57 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqblqj9we4.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox