From: Junio C Hamano <gitster@pobox.com>
To: "ryenus via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, ryenus <ryenus@gmail.com>
Subject: Re: [PATCH 1/1] fix-typo: consecutive-word duplications
Date: Thu, 05 Dec 2019 06:13:33 -0800 [thread overview]
Message-ID: <xmqqblsm273m.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <abb9e55ad5ef72242ee97e03316827b55ef2f4c8.1575517503.git.gitgitgadget@gmail.com> (ryenus via GitGitGadget's message of "Thu, 05 Dec 2019 03:45:03 +0000")
"ryenus via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: ryenus <ryenus@gmail.com>
>
> Correct unintentional duplication(s) of words, such as "the the",
> and "can can" etc.
Understood.
I would rather honor the original when it is not clearly wrong,
misleading to readers or prone to misunderstanding. Hence, I'd
rather not change this particular one.
> "we didn't do so so far" becomes "we didn't do that so far".
And also this one.
> * This should use the pathname to decide on whether it wants to do some
> * more interesting conversions (automatic gzip/unzip, general format
> - * conversions etc etc), but by default it just does automatic CRLF<->LF
> + * conversions etc), but by default it just does automatic CRLF<->LF
Everything else in this patch is improving what is clearly wrong and
is very much appreciated, though.
Just a reminder, as I do not know your cultural background so ryenus
in all lowercase may be your real name, in which case please ignore
this part of the response, but Documentation/SubmittingPatches says
[[real-name]]
Also notice that a real name is used in the Signed-off-by: line. Please
don't hide your real name.
about the Signed-off-by: line.
Thanks.
next prev parent reply other threads:[~2019-12-05 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 3:45 [PATCH 0/1] fix-typo: consecutive-word duplications ryenus via GitGitGadget
2019-12-05 3:45 ` [PATCH 1/1] " ryenus via GitGitGadget
2019-12-05 14:13 ` Junio C Hamano [this message]
2019-12-15 15:12 ` [PATCH v2 0/1] " ryenus via GitGitGadget
2019-12-15 15:12 ` [PATCH v2 1/1] " ryenus via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqblsm273m.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ryenus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).