From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2019, #05; Tue, 29)
Date: Thu, 31 Jan 2019 09:49:47 -0800 [thread overview]
Message-ID: <xmqqbm3w4szo.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190131074353.GA2647@archbookpro.localdomain> (Denton Liu's message of "Wed, 30 Jan 2019 23:43:53 -0800")
Denton Liu <liu.denton@gmail.com> writes:
> On Tue, Jan 29, 2019 at 02:15:36PM -0800, Junio C Hamano wrote:
>> * dl/merge-cleanup-scissors-fix (2019-01-27) 5 commits
>> - init docs: correct a punctuation typo
>> - merge: add scissors line on merge conflict
>> - merge: cleanup messages like commit
>> - t7600: clean up 'merge --squash c3 with c7' test
>> - commit: extract cleanup_mode functions to sequencer
>>
>> The list of conflicted paths shown in the editor while concluding a
>> conflicted merge was shown above the scissors line when the
>> clean-up mode is set to "scissors", even though it was commented
>> out just like the list of updated paths and other information to
>> help the user explain the merge better.
>>
>> Comments?
>
> Not a code review comment but I believe that you mistakenly included the
> "init docs" patch in the branch. That commit wasn't part of my patchset.
Thank you, thank you, thank you, for saving me from an
embarrassment.
Eh, now I am already embarrassed, but at least we won't see the
embarrassment cast in stone on 'next' and 'master' ;-)
next prev parent reply other threads:[~2019-01-31 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 22:15 What's cooking in git.git (Jan 2019, #05; Tue, 29) Junio C Hamano
2019-01-30 19:07 ` Jeff Hostetler
2019-01-31 17:43 ` Junio C Hamano
2019-01-31 7:43 ` Denton Liu
2019-01-31 17:49 ` Junio C Hamano [this message]
2019-01-31 17:59 ` mk/use-size-t-in-zlib [was: Re: What's cooking in git.git (Jan 2019, #05; Tue, 29)] Thomas Braun
2019-01-31 20:38 ` Torsten Bögershausen
2019-02-04 21:13 ` What's cooking in git.git (Jan 2019, #05; Tue, 29) Thomas Gummerer
2019-02-04 21:30 ` Junio C Hamano
2019-02-05 20:42 ` Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbm3w4szo.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox