From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Sven van Haastregt <svenvh@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-submodule.sh: shorten submodule SHA-1s using rev-parse
Date: Tue, 22 Jan 2019 12:23:55 -0800 [thread overview]
Message-ID: <xmqqbm48fnl0.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1901221623370.41@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Tue, 22 Jan 2019 16:24:26 +0100 (STD)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> + sha1_abbr_src=$(GIT_DIR="$name/.git" git rev-parse --short $sha1_src)
>
> How about `git -C "$name" rev-parse --short`? That would less likely run
> over 80 columns/line, either.
That would be a separate patch, either as a preliminary or a
follow-up. The existing code has too many of the same construct.
next prev parent reply other threads:[~2019-01-22 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 20:46 [PATCH] git-submodule.sh: shorten submodule SHA-1s using rev-parse Sven van Haastregt
2019-01-22 15:24 ` Johannes Schindelin
2019-01-22 20:23 ` Junio C Hamano [this message]
2019-01-24 21:49 ` Jeff King
2019-01-25 13:05 ` Johannes Schindelin
2019-01-22 20:22 ` Junio C Hamano
2019-01-22 21:38 ` Sven van Haastregt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbm48fnl0.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=svenvh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).