From: Junio C Hamano <gitster@pobox.com>
To: Nickolai Belakovski <nbelakovski@gmail.com>
Cc: sunshine@sunshineco.com, git@vger.kernel.org
Subject: Re: [PATCH] worktree: refactor lock_reason_valid and lock_reason to be more sensible
Date: Mon, 29 Oct 2018 15:42:31 +0900 [thread overview]
Message-ID: <xmqqbm7d45k8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAC05386YPtB5LmHFq3WrAaZ1vmZaBUdGr9hEbyR8KABzj+CzZQ@mail.gmail.com> (Nickolai Belakovski's message of "Sun, 28 Oct 2018 22:43:35 -0700")
Nickolai Belakovski <nbelakovski@gmail.com> writes:
> Either way, I do see an issue with the current code that anybody who
> wants to know the lock status and/or lock reason of a worktree gets
> faced with a confusing, misleading, and opaque piece of code.
Sorry, I don't. I do not mind a better documentation for
is_worktree_locked() without doing anything else.
I do not see any reason to remove fields, split the helper funciton
into two, drop the caching, etc., especially when the only
justification is "I am new to the codebase and find it confusing".
next prev parent reply other threads:[~2018-10-29 6:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 6:39 [PATCH] worktree: populate lock_reason in get_worktrees and light refactor/cleanup in worktree files nbelakovski
2018-10-24 8:11 ` Eric Sunshine
2018-10-25 5:46 ` Nickolai Belakovski
2018-10-25 5:51 ` [PATCH] worktree: refactor lock_reason_valid and lock_reason to be more sensible nbelakovski
2018-10-25 6:56 ` Junio C Hamano
2018-10-28 21:56 ` Nickolai Belakovski
2018-10-29 3:52 ` Junio C Hamano
2018-10-29 5:43 ` Nickolai Belakovski
2018-10-29 6:42 ` Junio C Hamano [this message]
[not found] ` <CAC05386cSUhBm4TLD5NUeb5Ut9GT5=h-1MvqDnFpuc+UdZFmwg@mail.gmail.com>
2018-10-28 23:02 ` Eric Sunshine
2018-10-29 1:10 ` Nickolai Belakovski
2018-10-29 4:01 ` Eric Sunshine
2018-10-29 5:45 ` Nickolai Belakovski
2018-10-29 6:21 ` Eric Sunshine
2018-10-30 6:24 ` [PATCH v3 1/2] worktree: update documentation for lock_reason and lock_reason_valid nbelakovski
2018-10-31 2:28 ` Junio C Hamano
2018-10-30 6:24 ` [PATCH v3 2/2] worktree: rename is_worktree_locked to worktree_lock_reason nbelakovski
2018-10-31 2:41 ` Junio C Hamano
2018-10-25 19:14 ` [PATCH] worktree: populate lock_reason in get_worktrees and light refactor/cleanup in worktree files Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbm7d45k8.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nbelakovski@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).