From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1505C2018B for ; Mon, 18 Jul 2016 18:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752390AbcGRSte (ORCPT ); Mon, 18 Jul 2016 14:49:34 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:56957 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752166AbcGRStc (ORCPT ); Mon, 18 Jul 2016 14:49:32 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 3A7182C8C0; Mon, 18 Jul 2016 14:49:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=kwSmN2R/VRtUgdNKako0kyCj9rY=; b=eUjVr4 vcxBahzu3MHYHw0hkKbKDUaIhy5twWggtEUCfzMczlfVSKrOWGK9x+TcrJHyztrj s/4pJVza4x94pbiyJ4EQx6eI7bxbhge7OvG8OSyf17ybIr3fCHyrRcaCoBK6+BI5 Mll2Fug+8M3llCihFez7oV27J40cpSWszmQic= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=DY2CTbLfaRYuElwNiA4wa9mOBz6R9Ay2 nOIX9VjwJUnWfZP4abywu6Y12Z7gvySjNUQM3avHBJ53yFCUFxBrOLykHVMs87KE 2uIqejHd5qSIl7Yuelt6CQMY0o0NBBwBMFrOFJycmzznh5Cu0jwZknGctsgPX3no aqjAL8NSoEM= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 335AC2C8BF; Mon, 18 Jul 2016 14:49:31 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id AF3F82C8BE; Mon, 18 Jul 2016 14:49:30 -0400 (EDT) From: Junio C Hamano To: Mike Hommey Cc: git@vger.kernel.org Subject: Re: [PATCH] blame: Allow to blame paths freshly added to the index References: <20160715024254.29186-1-mh@glandium.org> <20160715231656.iztvtftk5ttrzeow@glandium.org> Date: Mon, 18 Jul 2016 11:49:28 -0700 In-Reply-To: <20160715231656.iztvtftk5ttrzeow@glandium.org> (Mike Hommey's message of "Sat, 16 Jul 2016 08:16:56 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5C77CB90-4D18-11E6-BC91-EE617A1B28F4-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Mike Hommey writes: >> I suspect that this would be useful without copy detection. If you >> "git mv fileA fileB" (optionally followed by "edit fileB"), fileB >> would not be in HEAD but you should be able to trace the lineage of >> the lines in it back through the renaming event, and this change >> also allows that use case, no? > > It should, but that'd be copy/move detection, wouldn't it? :) Actually, in the context of "git blame", there is no extra "detection" needed for following a whole file rename. >> But the user can be in the same conflicted rename situation with >> "git am -3" or cherry-pick, and in these cases there won't be extra >> parent commits for the fake work tree commit, hence the conclusion >> does not change. > > Indeed, with cherry-pick, the "no such path in HEAD" error is happening > with the patch. OK.