From: Junio C Hamano <gitster@pobox.com>
To: "Rémi Lespinet" <remi.lespinet@gmail.com>
Cc: Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
git@vger.kernel.org,
Remi Galan <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH 2/2] send-email: allow multiple emails using --cc, --to and --bcc
Date: Tue, 02 Jun 2015 10:19:25 -0700 [thread overview]
Message-ID: <xmqqbngy3u5e.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CA+V2YBvP89=b5SFbkUVnEzaPT2aCiK9XN1Hd6qsN8HCmxxB+GA@mail.gmail.com> ("Rémi Lespinet"'s message of "Tue, 2 Jun 2015 10:26:11 +0200")
Rémi Lespinet <remi.lespinet@gmail.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> The reason why we have the "verify the input" thing, allow users to
>> supply multiple --to/--cc/etc., and do not try to split the
>> addresses ourselves is because we want to avoid mistakenly splitting
>> a single address like the above into two and producing syntactically
>> incorrect addresses. People have relied on the current behaviour
>> for a long time, without manually dropping comma when they send
>> their patches with --to='"Jane, Doe" <jdoe@example.com>'.
>
> Yes, but they couldn't send with --to='"Jane, Doe" <jdoe@example.com>'
> anyway since 79ee555b (Check and document the options to prevent
> mistakes. 2006-06-21). So I don't think that this part is a
> regression.
Ahh, stupid me. Thanks.
Then starting with the "split at the comma" implementation is
perfectly fine. People will learn not to use '"Doe, Jane" <jdoe>'
because that will not work while the implementation is limited, and
later when it is enhanced, they can start using that form.
prev parent reply other threads:[~2015-06-02 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 14:14 [PATCH 1/2] t9001-send-email: create a function replacing variable fields Remi Lespinet
2015-06-01 14:14 ` [PATCH 2/2] send-email: allow multiple emails using --cc, --to and --bcc Remi Lespinet
2015-06-01 15:12 ` Matthieu Moy
2015-06-01 15:19 ` Junio C Hamano
2015-06-01 16:52 ` Junio C Hamano
2015-06-02 8:26 ` Rémi Lespinet
2015-06-02 17:19 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbngy3u5e.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox