From: Junio C Hamano <gitster@pobox.com>
To: Noam Cohen via B4 Relay <devnull+noam.noam.me@kernel.org>
Cc: git@vger.kernel.org, "Teng Long" <dyroneteng@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"René Scharfe" <l.s.r@web.de>, "Noam Cohen" <noam@noam.me>
Subject: Re: [PATCH] ls-tree: do not quote %(path) with -z
Date: Wed, 18 Nov 2026 15:20:39 -0800 [thread overview]
Message-ID: <xmqqcxs120c8.fsf@gitster.g> (raw)
In-Reply-To: <20261118-ls-tree-format-z-verbatim-path-v1-1-718987241861@noam.me> (Noam Cohen via's message of "Wed, 18 Nov 2026 23:04:37 +0000")
Noam Cohen via B4 Relay <devnull+noam.noam.me@kernel.org> writes:
> From: Noam Cohen <noam@noam.me>
>
> With -z, "git ls-tree" is documented to output the filename verbatim,
> but since 455923e0a1 (ls-tree: introduce "--format" option,
> 2022-03-23) the %(path) placeholder of a custom --format is always
> C-quoted.
>
> Output it verbatim when -z is given, like "git ls-files --format"
> already does.
ce74de931d (ls-files: introduce "--format" option, 2022-07-23) was
the one that added --format, and the documentation added by the
commit does talk about -z. But curiously, it does not add any test
that exercises --format="%(path)" combined with -z.
The code change is trivially correct.
> test_expect_success 'setup' '
> - setup_basic_ls_tree_data
> + setup_basic_ls_tree_data &&
> + test_commit נעם
> '
Do we have to really use characters outside US-ASCII?
> @@ -76,4 +77,10 @@ test_ls_tree_format \
> "--full-tree" \
> "--full-tree"
>
> +test_expect_success 'ls-tree --format with -z does not quote paths' '
> + printf "blob נעם.t\0" >expect &&
> + git ls-tree -z --format="%(objecttype) %(path)" HEAD נעם.t >actual &&
OK, perhaps.
prev parent reply other threads:[~2026-11-18 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 23:04 [PATCH] ls-tree: do not quote %(path) with -z Noam Cohen via B4 Relay
2026-11-18 23:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcxs120c8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=devnull+noam.noam.me@kernel.org \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=noam@noam.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox