Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Hardik Kumar <hardikxk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t: use test_must_fail instead of NOT operator
Date: Mon, 16 Nov 2026 08:07:11 -0800	[thread overview]
Message-ID: <xmqqcxs4n4k0.fsf@gitster.g> (raw)
In-Reply-To: <20261115-t-tmf-refactor-v1-1-d7a95cdeaedd@gmail.com> (Hardik Kumar's message of "Sun, 15 Nov 2026 23:45:21 +0530")

Hardik Kumar <hardikxk@gmail.com> writes:

> Replace `!` operator with `test_must_fail` for multiple unit tests where
> a git command is expected to fail.
>
> `test_must_fail` handles edge cases like a command killed by a signal
> or a crash because of a segfault, by actually failing the test unlike
> the `!` operator which would result in the test being passed as the
> crash is accepted as a failure (the test is expected to fail).
>
> Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
> ---
>  t/t5564-http-proxy.sh       | 4 ++--
>  t/t6030-bisect-porcelain.sh | 4 ++--
>  t/t7400-submodule-basic.sh  | 4 ++--
>  t/t9001-send-email.sh       | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)

All of them look sensible, but I am curious why you chose only
these, among 14 hits in

    $ git grep -l '^[ 	]*! git ' t/

I suspect that it is because these are ...

> -	! git clone -c http.proxy=localhost/path https://example.com/repo.git 2>err && {
> -	! git clone -c http.proxy=socks4://127.0.0.1/path https://example.com/repo.git 2>err && {
> -	! git bisect run ./fail.sh 2>err &&
> -	! git bisect run ./fail.sh 2>err &&

... simple cases in which the use of leading ! negation is the only
issue with them, and if that is the reasoning, I think that is
sensible.  Contrasting these, many of the hits in t2206 (one among
14 hits in the above grep), for example, look like this:

  ! git status --porcelain | grep "^.*$" &&

which violates "do not hide exit status of git behind a pipe" rule,
in addition to have a strange looking leading ! negation.

Will queue.

  reply	other threads:[~2026-11-16 16:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 18:15 [PATCH] t: use test_must_fail instead of NOT operator Hardik Kumar
2026-11-16 16:07 ` Junio C Hamano [this message]
2026-11-16 17:33   ` Hardik Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcxs4n4k0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hardikxk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox