From: Junio C Hamano <gitster@pobox.com>
To: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Cc: "Tilak Kumar" <raaztilak07@gmail.com>, <git@vger.kernel.org>
Subject: Re: [GSoC PATCH] t5402: use test_path_* helpers instead of test -e and test -f
Date: Thu, 29 Oct 2026 13:32:16 -0700 [thread overview]
Message-ID: <xmqqcxss1c4v.fsf@gitster.g> (raw)
In-Reply-To: <DMHLKVCPT29F.1JXB7BAOXBPYT@fastmail.com> (Mark C. Chu-Carroll's message of "Thu, 29 Oct 2026 16:17:13 -0400")
"Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
> On Thu Oct 29, 2026 at 4:00 PM EDT, Tilak Kumar wrote:
>> Use test_path_exists and test_path_is_missing instead of "test -e"
>> and "! test -f" in the post-merge hook tests, so that a failure
>> reports which path was unexpectedly missing or present instead of
>> failing silently.
>>
>> Signed-off-by: Tilak Kumar <raaztilak07@gmail.com>
>> ...
>>
>> test_expect_success 'post-merge from squash merge runs as expected ' '
>> GIT_DIR=clone2/.git git merge --squash $commit1 &&
>> - test -e clone2/.git/post-merge.args
>> + test_path_exists clone2/.git/post-merge.args
>> '
>>
>> test_expect_success 'post-merge from squash merge receives the right argument ' '
>
> looks correct to me.
Thanks for writing and reviewing. Queued.
prev parent reply other threads:[~2026-10-29 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 20:00 [GSoC PATCH] t5402: use test_path_* helpers instead of test -e and test -f Tilak Kumar
2026-10-29 20:17 ` Mark C. Chu-Carroll
2026-10-29 20:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcxss1c4v.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=markchucarroll@fastmail.com \
--cc=raaztilak07@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox