From: Junio C Hamano <gitster@pobox.com>
To: Tanga Joris <tangajoris@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
siddharthasthana31@gmail.com, kaartic.sivaraam@gmail.com,
usmanakinyemi202@gmail.com, taahol@utu.fi,
ibnmuhyideen95@gmail.com
Subject: Re: [Outreachy PATCH v2] checkout: use Q_() for messages with counts
Date: Fri, 23 Oct 2026 10:55:44 -0700 [thread overview]
Message-ID: <xmqqcxt0713z.fsf@gitster.g> (raw)
In-Reply-To: <20261022004834.246892-1-tangajoris@gmail.com> (Tanga Joris's message of "Thu, 22 Oct 2026 03:48:34 +0300")
Tanga Joris <tangajoris@gmail.com> writes:
> - Also converted "only one reference expected, %d given.",
> as discussed by Tuomas in Mudi's thread.
>
> Interdiff against v1:
> diff --git a/builtin/checkout.c b/builtin/checkout.c
> index 49239f029f..91b7c52396 100644
> --- a/builtin/checkout.c
> +++ b/builtin/checkout.c
> @@ -1491,7 +1491,9 @@ static int parse_branchname_arg(int argc, const char **argv,
> else if (dash_dash_pos == 1)
> has_dash_dash = 1; /* case (3) or (1) */
> else if (dash_dash_pos >= 2)
> - die(_("only one reference expected, %d given."), dash_dash_pos);
> + die(Q_("only one reference expected, %d given.",
> + "only one reference expected, %d given.",
> + dash_dash_pos), dash_dash_pos);
> opts->count_checkout_paths = !opts->quiet && !has_dash_dash;
>
> if (!strcmp(arg, "-"))
>
> builtin/checkout.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Looks good to me. Will queue. Thanks.
prev parent reply other threads:[~2026-10-23 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 2:21 [Outreachy PATCH] checkout: use Q_() for the "... and %d more" message Tanga Joris
2026-10-21 18:04 ` Junio C Hamano
2026-10-21 21:04 ` Tanga Joris
2026-10-22 0:48 ` [Outreachy PATCH v2] checkout: use Q_() for messages with counts Tanga Joris
2026-10-23 17:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcxt0713z.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=ibnmuhyideen95@gmail.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=siddharthasthana31@gmail.com \
--cc=taahol@utu.fi \
--cc=tangajoris@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox