Re: [PATCH] revision: make get_commit_action() a pure predicate

[Junio C Hamano <gitster@pobox.com>]

Michael Montalbo <mmontalbo@gmail.com> writes:

> On Fri, Jul 24, 2026 at 2:38 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Sorry, but I completely lost track and I do not recall suggesting a
>> change that amounts to 100+ lines of new lines.  Are we doing any
>> code clean-up?  Bugfix?  A new feature?
>
> A latent bug fix, but I understand why this was confusing.
>
> This was the discussion I should have linked to:
>
> https://lore.kernel.org/git/xmqqtsqxfdl4.fsf@gitster.g/.
>
> I had the link in my GGG PR description but accidentally deleted it
> without re-adding when I remembered GGG PRs shouldn't use a
> description for one commit series.

Ah, I recall that discussion.

> Unfortunately, I couldn't figure out a way to make a test that
> validates if the change is effective without creating a bespoke
> test-tool that calls the function with the "right" options set.

Understandable, as it does not fix an active bug so much as clean up
the API to make it harder to introduce bugs in code that calls it.

Thanks.