Re: [GSoC PATCH v2] backfill: error out when HEAD cannot be parsed

[Junio C Hamano <gitster@pobox.com>]

Trieu Huynh <vikingtc4@gmail.com> writes:

> From: Trieu Huynh <vikingtc4@gmail.com>
>
> handle_revision_arg() returns non-zero on failure, but do_backfill()
> ignores the return value. On an empty repo with no commits, HEAD is
> unborn and handle_revision_arg() fails, but backfill silently
> continues with an empty revision walk and exists with a zero return
> code.

"exists" -> "exits", I think.

But more importantly (with Devil's advocate hat on), what's the
downside of the current behaviour?

You tell the command to backfill, the machinery does not find
anything necessary to fetch to backfill, and successfully, quickly,
and quietly exits.  That sounds like a graceful exit to me.

Is there anything wrong with that?

> +test_expect_success 'backfill on empty repo fails gracefully' '
> +	git init empty-repo &&
> +	test_must_fail git -C empty-repo backfill 2>err &&
> +	test_grep "unable to parse HEAD" err
> +'