From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
Gusted <gusted@codeberg.org>
Subject: Re: [PATCH v2 2/5] last-modified: add option '-z' to help output
Date: Fri, 16 Jan 2026 10:31:13 -0800 [thread overview]
Message-ID: <xmqqcy398l5a.fsf@gitster.g> (raw)
In-Reply-To: <20260116-toon-last-modified-zzzz-v2-2-79e44f2806fe@iotcl.com> (Toon Claes's message of "Fri, 16 Jan 2026 14:22:50 +0100")
Toon Claes <toon@iotcl.com> writes:
> + OPT_BOOL('z', NULL, &lm.null_termination,
> + N_("lines are separated with NUL character")),
As this is a name of a file-scope static thing, I do not think it
matters too much, but "&lm.null_termination" (instead of
"nul_termination") that controls use of "NUL character" somewhat
bothers me ;-).
next prev parent reply other threads:[~2026-01-16 18:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 6:09 [PATCH 0/3] Expand and enhance git-last-modified(1) documentation Toon Claes
2025-11-26 6:09 ` [PATCH 1/3] last-modified: handle and document NUL termination Toon Claes
2025-11-26 13:03 ` Karthik Nayak
2025-11-26 16:57 ` Junio C Hamano
2025-11-28 18:50 ` Toon Claes
2025-12-01 10:32 ` Patrick Steinhardt
2025-11-26 6:09 ` [PATCH 2/3] last-modified: document option --max-depth Toon Claes
2025-11-26 13:31 ` Karthik Nayak
2026-01-16 12:13 ` Toon Claes
2025-11-26 19:49 ` Junio C Hamano
2025-11-28 18:51 ` Toon Claes
2025-11-26 6:09 ` [PATCH 3/3] last-modified: better document how depth in handled Toon Claes
2025-11-26 17:38 ` Eric Sunshine
2025-12-01 10:32 ` Patrick Steinhardt
2025-12-02 11:01 ` Toon Claes
2025-12-02 17:14 ` Patrick Steinhardt
2026-01-16 13:22 ` [PATCH v2 0/5] Change git-last-modified(1) default behavior and add documentation Toon Claes
2026-01-16 13:22 ` [PATCH v2 1/5] last-modified: document NUL termination Toon Claes
2026-01-16 13:22 ` [PATCH v2 2/5] last-modified: add option '-z' to help output Toon Claes
2026-01-16 18:31 ` Junio C Hamano [this message]
2026-01-16 13:22 ` [PATCH v2 3/5] last-modified: document option --max-depth Toon Claes
2026-01-16 13:22 ` [PATCH v2 4/5] last-modified: add option '--max-depth' to help output Toon Claes
2026-01-16 18:42 ` Junio C Hamano
2026-01-16 13:22 ` [PATCH v2 5/5] last-modified: change default max-depth to 0 Toon Claes
2026-01-16 18:55 ` Junio C Hamano
2026-01-16 13:34 ` [PATCH v2 0/5] Change git-last-modified(1) default behavior and add documentation Kristoffer Haugsbakk
2026-01-20 10:44 ` Toon Claes
2026-01-20 21:47 ` [PATCH v3 0/4] " Toon Claes
2026-01-20 21:47 ` [PATCH v3 1/4] last-modified: clarify in the docs the command takes a pathspec Toon Claes
2026-01-20 21:47 ` [PATCH v3 2/4] last-modified: document option '-z' Toon Claes
2026-01-20 21:47 ` [PATCH v3 3/4] last-modified: document option '--max-depth' Toon Claes
2026-01-20 21:47 ` [PATCH v3 4/4] last-modified: change default max-depth to 0 Toon Claes
2026-01-25 11:24 ` Kristoffer Haugsbakk
2026-01-21 18:40 ` [PATCH v3 0/4] Change git-last-modified(1) default behavior and add documentation Junio C Hamano
2026-02-03 9:58 ` Karthik Nayak
2026-02-03 17:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcy398l5a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gusted@codeberg.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox