From: Junio C Hamano <gitster@pobox.com>
To: Aaron Plattner <aplattner@nvidia.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Lucas De Marchi <demarchi@kernel.org>
Subject: Re: [PATCH v2] remote-curl: Use auth for probe_rpc() requests too
Date: Wed, 14 Jan 2026 09:41:21 -0800 [thread overview]
Message-ID: <xmqqcy3cf5xa.fsf@gitster.g> (raw)
In-Reply-To: <613b47af-5269-44e3-87f5-d29fba9d73b3@nvidia.com> (Aaron Plattner's message of "Wed, 14 Jan 2026 08:33:43 -0800")
Aaron Plattner <aplattner@nvidia.com> writes:
> Is it worth changing up the other cases of this pattern, mostly in
> pack-refs-tests.sh? E.g.,
>
> # Create 15 loose references.
> printf "create refs/heads/loose-%d HEAD\n" $(test_seq 15) >stdin &&
> git update-ref --stdin <stdin &&
>
> [...]
>
> # Create 99 packed refs. This should cause the heuristic
> # to require more than the minimum amount of loose refs.
> test_seq 99 |
> while read i
> do
> printf "create refs/heads/packed-%d HEAD\n" $i || return 1
> done >stdin &&
> git update-ref --stdin <stdin &&
>
> I can put together a patch for those.
I am fairly sure that these existing ones were written way before
the feature in test_seq to use the format parameter got popular. A
separate patch to clean them up would be a good addition but of
course should be outside the current topic ;-)
Thanks.
prev parent reply other threads:[~2026-01-14 17:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 3:19 [PATCH v2] remote-curl: Use auth for probe_rpc() requests too Aaron Plattner
2026-01-13 6:49 ` Patrick Steinhardt
2026-01-13 13:09 ` Junio C Hamano
2026-01-14 1:06 ` Aaron Plattner
2026-01-14 2:20 ` Jeff King
2026-01-14 14:11 ` Junio C Hamano
2026-01-14 16:33 ` Aaron Plattner
2026-01-14 17:30 ` Jeff King
2026-01-14 17:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcy3cf5xa.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aplattner@nvidia.com \
--cc=demarchi@kernel.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox