git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org,
	"Kristoffer Haugsbakk" <code@khaugsbakk.name>,
	"Jean-Noël Avila" <jn.avila@free.fr>
Subject: Re: [PATCH] doc: patch-id: convert to the modern synopsis style
Date: Fri, 10 Oct 2025 01:50:43 -0700	[thread overview]
Message-ID: <xmqqcy6vb0nw.fsf@gitster.g> (raw)
In-Reply-To: <978261e3be4.1760043036.git.code@khaugsbakk.name> (kristofferhaugsbakk@fastmail.com's message of "Thu, 9 Oct 2025 22:53:53 +0200")

kristofferhaugsbakk@fastmail.com writes:

>     This depends on the topic kh/doc-patch-id-markup-fix (39969438 (doc:
>     patch-id: fix accidental literal blocks, 2025-09-29) merged into
>     v2.50.0 (because that’s what the topic is based on).
>     
>     (is there a “reference” convention for mentioning a topic + commit?)

The above is perfectly understandable.

>     This is part one of a multi-series effort focusing on this
>     documentation page. Technically that intent started with topic
>     kh/doc-patch-id-markup-fix, but I published that before I learned
>     about the idea presented in <cover.1759873165.git.me@ttaylorr.com>.
>     So this gets named “part one” in the cover letter (and maybe on the
>     topic name).
>     
>     The current plan for parts 2–5:
>     
>     2. Various smaller fixups (many small patches/commits)
>     3. Mention the two config variables in git-config(1)
>     4. Make it more clear that you can feed multiple diffs to this command
>     5. An “Examples” section

Quite honestly, this smells like making a mountain out of a
molehill.  5-patch topic that focuses on improving a single
documentation page is nothing unusual, but it is very unusual and
awkward to handle for a topic that focuses on improving a single
documentation page is spread across 5 separate topics, each building
on top of the previous one.

>     Why a multi-part series?  It started with the idea of (1) emphasizing
>     that this command can take multiple patches, and (2) making an
>     Examples. But then I saw other things to fix. And they ought to go
>     first... eventually I ended up with many commits or ideas.

Perhaps then after you built up the final shape, you'd need time to
ruminate over it and possibly reorganize to find the best order and
organization to present it as a N-patch single series?  Typically, a
collection of thoughts presented in the order they came to one's mind
is much harder to judge, relative to an effort to tell a coherent story
that moves to a goal.

But we'll see.

  parent reply	other threads:[~2025-10-10  8:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 20:53 [PATCH] doc: patch-id: convert to the modern synopsis style kristofferhaugsbakk
2025-10-10  5:06 ` Jeff King
2025-10-13 15:03   ` Kristoffer Haugsbakk
2025-10-10  6:48 ` Jean-Noël Avila
2025-10-13 14:54   ` Kristoffer Haugsbakk
2025-10-10  8:50 ` Junio C Hamano [this message]
2025-10-13 16:42   ` Kristoffer Haugsbakk
2025-10-13 15:42 ` [PATCH v2] " kristofferhaugsbakk
2025-10-13 16:53   ` Eric Sunshine
2025-10-14 20:46     ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcy6vb0nw.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).