git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Ramsay Jones <ramsay@ramsayjones.plus.com>,
	irecca.kun@gmail.com,  Eli Schwartz <eschwartz@gentoo.org>,
	 Jeff King <peff@peff.net>,  Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v3 2/8] meson: stop printing 'https' option twice in our summaries
Date: Wed, 09 Jul 2025 08:17:23 -0700	[thread overview]
Message-ID: <xmqqcya9pf5o.fsf@gitster.g> (raw)
In-Reply-To: <20250709-b4-pks-meson-cleanups-v3-2-29ab15b9ab85@pks.im> (Patrick Steinhardt's message of "Wed, 09 Jul 2025 08:23:36 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> The value for the 'https' backend option is printed twice: once via the
> summary of auto-detected features and once via our summary of backends.
> Drop it from the former summary.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  meson.build | 1 -
>  1 file changed, 1 deletion(-)

Good eyes.  To me the distinction between "Auto-detected features"
and "Backends" feel a bit blurry, but most of the things in the
former are what dependency() returned, while https_backend is very
much driven by custom code of ours, so removing from "Auto-detected"
does make senseto me.

Thanks.


> diff --git a/meson.build b/meson.build
> index 4ee1a55b0bb..0ed00254ef3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2200,7 +2200,6 @@ summary({
>    'expat': expat.found(),
>    'gettext': intl.found(),
>    'gitweb': gitweb_option.allowed(),
> -  'https': https_backend,
>    'iconv': iconv.found(),
>    'pcre2': pcre2.found(),
>    'perl': perl_features_enabled,

  reply	other threads:[~2025-07-09 15:17 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  9:28 [PATCH 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-08 19:38   ` Justin Tobler
2025-07-09  6:16     ` Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-08 19:56   ` Justin Tobler
2025-07-03  9:28 ` [PATCH 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-03 16:39   ` Ramsay Jones
2025-07-08  8:44     ` Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-03  9:28 ` [PATCH 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-08  0:16   ` Junio C Hamano
2025-07-08  1:12     ` Jeff King
2025-07-08  1:39       ` Jeff King
2025-07-08  4:39         ` Junio C Hamano
2025-07-08  7:16         ` Patrick Steinhardt
2025-07-08  7:57 ` [PATCH v2 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-08 20:44     ` Justin Tobler
2025-07-08  7:57   ` [PATCH v2 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-08  7:57   ` [PATCH v2 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-09  6:23 ` [PATCH v3 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-09 15:09     ` Junio C Hamano
2025-07-09 21:36       ` Justin Tobler
2025-07-09 22:22       ` Eli Schwartz
2025-07-09 22:40         ` Junio C Hamano
2025-07-09  6:23   ` [PATCH v3 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-09 15:17     ` Junio C Hamano [this message]
2025-07-09  6:23   ` [PATCH v3 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-10 15:25     ` Toon Claes
2025-07-10 16:24       ` Junio C Hamano
2025-07-09  6:23   ` [PATCH v3 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-09  6:23   ` [PATCH v3 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-09 21:37   ` [PATCH v3 0/8] A handful of Meson cleanups and improvements Justin Tobler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcya9pf5o.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=eschwartz@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=irecca.kun@gmail.com \
    --cc=jltobler@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).