From: Junio C Hamano <gitster@pobox.com>
To: "Derick W. de M. Frias" <derick.william.moraes@gmail.com>
Cc: j6t@kdbg.org, git@vger.kernel.org
Subject: Re: [PATCH v2 1/4] userdiff: add javascript diff driver
Date: Mon, 23 Jun 2025 11:09:35 -0700 [thread overview]
Message-ID: <xmqqcyau5nz4.fsf@gitster.g> (raw)
In-Reply-To: <20250623090538.154858-2-derick.william.moraes@gmail.com> (Derick W. de M. Frias's message of "Mon, 23 Jun 2025 03:35:46 -0300")
"Derick W. de M. Frias" <derick.william.moraes@gmail.com> writes:
> --- a/userdiff.c
> +++ b/userdiff.c
> @@ -238,33 +238,43 @@ PATTERNS("java",
> "|[-+*/<>%&^|=!]="
> "|--|\\+\\+|<<=?|>>>?=?|&&|\\|\\|"),
> PATTERNS("javascript",
> - /* conventional named functions */
> - "^[ \t]*(async[ \t]+)?function[ \t]*\\*?[ \t]*([$_a-zA-Z][$_a-zA-Z0-9]*)[ \t]*\\(.*$|"
Curious to see that anything needs to be removed from "javascript"
section, when we do not have any patterns for the language in the
file. Which version of Git is this patch meant to apply to?
next prev parent reply other threads:[~2025-06-23 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 9:35 [GSoC PATCH 0/1] userdiff: add javascript diff driver Derick W. de M. Frias
2025-06-04 9:35 ` [GSoC PATCH 1/1] " Derick W. de M. Frias
2025-06-04 21:19 ` D. Ben Knoble
2025-06-05 5:51 ` Johannes Sixt
2025-06-23 6:35 ` [PATCH v2 0/4] diff: create pattern for javascript language Derick W. de M. Frias
2025-06-23 6:35 ` [PATCH v2 1/4] userdiff: add javascript diff driver Derick W. de M. Frias
2025-06-23 18:09 ` Junio C Hamano [this message]
2025-06-23 6:35 ` [PATCH v2 2/4] t4034: add tests for javascript word literals Derick W. de M. Frias
2025-06-23 6:35 ` [PATCH v2 3/4] t4018: add tests for recognizing javascript function syntax Derick W. de M. Frias
2025-06-23 6:35 ` [PATCH v2 4/4] t4018: add tests for javascript export type function declarations Derick W. de M. Frias
2025-06-26 6:21 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyau5nz4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derick.william.moraes@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).