From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Patrik Weiskircher" <patrik.weiskircher@nutrient.io>,
"D. Ben Knoble" <ben.knoble@gmail.com>,
"Josh Soref" <gitgitgadget@gmail.com>,
git@vger.kernel.org, apenwarr@gmail.com
Subject: Re: [PATCH 1/2] contrib/subtree: parse using --stuck-long
Date: Wed, 04 Jun 2025 08:41:05 -0700 [thread overview]
Message-ID: <xmqqcybjcy5q.fsf@gitster.g> (raw)
In-Reply-To: <0c65723e-fb52-43e1-8bf2-32bd421163a1@app.fastmail.com> (Kristoffer Haugsbakk's message of "Wed, 04 Jun 2025 16:09:33 +0200")
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
> On Wed, Jun 4, 2025, at 15:56, Patrik Weiskircher wrote:
>>>
>>> Here we mention "-S", but that flag isn't implemented yet, right?
>>>
>>> Perhaps something like:
>>>
>>> Optional parameter handling only works unambiguous with git rev-parse
>>> --parseopt when using the --stuck-long option. To prepare for future commits
>>> which add flags with optional parameters, parse with --stuck-long.
>>>
>>
>> Makes sense! Changing that. What is a good policy to resubmit
>> something? Should I wait longer? Sorry, very new here!
>
> • Force-push your branch to gitgitgadget
> • Edit the PR description with something like “Changes since v1:” to
> summarize the changes
> • (`/preview` comment)
> • To send the next version: `/submit` comment again
>
> I think that’s it. :)
>
> I don’t think there’s a need to wait if you don’t want to.
It would be nice for potential reviewers to give at least 24 hours
to ensure people anywhere on the globe have a chance to comment, and
a chance for you to respond to them, before sending your next
iteration.
Also, for future reference, when responding to a review comment that
causes you to drastically change the course of the series, you can
respond whenever you want to, but it is nice to other potential
reviewers to give at least 24 hours to voice their opinions, before
sending an updated series based on that comment, since suggested
changes in such a comment may be controversial and after seeing you
spend some time already to adjust to it, others may feel discouraged
to make you redo your series again even whey they think the
suggested changes are not taking us in the right direction.
next prev parent reply other threads:[~2025-06-04 15:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 16:40 [PATCH 0/2] contrib/subtree: Add -S/-gpg-sign Patrik Weiskircher via GitGitGadget
2025-06-02 16:40 ` [PATCH 1/2] contrib/subtree: parse using --stuck-long Patrik Weiskircher via GitGitGadget
2025-06-03 20:42 ` D. Ben Knoble
2025-06-04 13:56 ` Patrik Weiskircher
2025-06-04 14:09 ` Kristoffer Haugsbakk
2025-06-04 15:41 ` Junio C Hamano [this message]
2025-06-04 15:43 ` Patrik Weiskircher
2025-06-02 16:40 ` [PATCH 2/2] contrib/subtree: add -S/--gpg-sign Patrik Weiskircher via GitGitGadget
2025-06-04 14:16 ` [PATCH v2 0/2] contrib/subtree: Add -S/-gpg-sign Patrik Weiskircher via GitGitGadget
2025-06-04 14:16 ` [PATCH v2 1/2] contrib/subtree: parse using --stuck-long Patrik Weiskircher via GitGitGadget
2025-06-04 14:16 ` [PATCH v2 2/2] contrib/subtree: add -S/--gpg-sign Patrik Weiskircher via GitGitGadget
2025-06-04 16:33 ` [PATCH v2 0/2] contrib/subtree: Add -S/-gpg-sign Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcybjcy5q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=apenwarr@gmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=patrik.weiskircher@nutrient.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).