git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eli Schwartz <eschwartz@gentoo.org>
Cc: Patrick Steinhardt <ps@pks.im>,
	 git@vger.kernel.org,  Peter Seiderer <ps.report@gmx.net>,
	 Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v3 2/2] meson: prefer shell at "/bin/sh"
Date: Fri, 25 Apr 2025 11:51:02 -0700	[thread overview]
Message-ID: <xmqqcyd0t6qx.fsf@gitster.g> (raw)
In-Reply-To: <06e57780-9f59-4166-81d3-9cd0c1c66b7e@gentoo.org> (Eli Schwartz's message of "Fri, 25 Apr 2025 14:07:18 -0400")

Eli Schwartz <eschwartz@gentoo.org> writes:

> On 4/25/25 1:04 PM, Junio C Hamano wrote:
>> Now I am showing my ignorance, but does this support folks whose
>> shell are not spelled "sh" (like "/usr/local/bin/dash"), and more
>> importantly, if it does not, shouldn't we be using a mechanism that
>> does?  I think -Dsane_tool_path=/usr/local/bin would help with the
>> leading directory path, but I suspect that find_program() does not
>> help specifying "dash" to be used as our target_shell (or host
>> shell), or "perl5" as our perl.
>> 
>> Of course, this "my sh is called dash" can be left totally outside
>> of the topic of these two patches.
>
>
> POSIX does not require a specific absolute file path for "sh", but it
> does mandate that you have a shell and its name is "sh", whichever
> directory it may be found in.
> ...
> There is (most of the time) not actually a program called "sh". Various
> different programs may provide a symlink "sh", pointing to their own shell:

Exactly.  And with many systems being personal these days, /bin/sh
may point at a shell that is better for interactive use (like
"bash"), while the user may prefer another (like "dash") scripted
use that is not pointed by that single /bin/sh symbolic link.

In any case, we live in real world where things are not strictly
POSIX.  Our Makefile does support with SHELL_PATH "sh", "dash", and
"bash" just fine.  Why shouldn't I wish for feature parity in a new
build framework that aims to at least compete and become an
alternative?


  reply	other threads:[~2025-04-25 18:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 13:38 [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Patrick Steinhardt
2025-04-24 13:38 ` [PATCH 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25  0:45   ` Eli Schwartz
2025-04-25  5:21     ` Patrick Steinhardt
2025-04-25 16:34       ` Junio C Hamano
2025-04-24 13:38 ` [PATCH 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-24 20:18   ` Justin Tobler
2025-04-25  5:21     ` Patrick Steinhardt
2025-04-24 18:28 ` [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-04-25  5:21   ` Patrick Steinhardt
2025-04-25  5:47 ` [PATCH v2 " Patrick Steinhardt
2025-04-25  5:47   ` [PATCH v2 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25  8:27     ` Toon Claes
2025-04-25  5:47   ` [PATCH v2 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-25  8:35     ` Toon Claes
2025-04-25 10:49     ` brian m. carlson
2025-04-25 11:52       ` Patrick Steinhardt
2025-04-25 11:24   ` [PATCH v2 0/2] meson: prefer '/bin/sh' over PATH lookup Toon Claes
2025-04-25 14:11 ` [PATCH v3 " Patrick Steinhardt
2025-04-25 14:11   ` [PATCH v3 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25 14:11   ` [PATCH v3 2/2] meson: prefer shell at "/bin/sh" Patrick Steinhardt
2025-04-25 17:04     ` Junio C Hamano
2025-04-25 18:07       ` Eli Schwartz
2025-04-25 18:51         ` Junio C Hamano [this message]
2025-04-25 22:21           ` Eli Schwartz
2025-04-25 20:10         ` brian m. carlson
2025-04-25 22:25           ` Eli Schwartz
2025-04-25 20:13     ` brian m. carlson
2025-05-02 21:16   ` [PATCH v3 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-05-02 22:37     ` Eli Schwartz
2025-05-05  6:08       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcyd0t6qx.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=eschwartz@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=ps.report@gmx.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).