From: Junio C Hamano <gitster@pobox.com>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info
Date: Tue, 22 Apr 2025 15:25:45 -0700 [thread overview]
Message-ID: <xmqqcyd33kba.fsf@gitster.g> (raw)
In-Reply-To: <20250422213133.18685-1-lucasseikioshiro@gmail.com> (Lucas Seiki Oshiro's message of "Tue, 22 Apr 2025 18:31:34 -0300")
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
> Remove the log_reencode field from struct rev-info, as it is not used.
> This field was introduced in 52883fb, but it hasn't been used since its
> introduction.
"52883fbd (Teach log family --encoding, 2006-12-25)" is how you
would refer to existing commit in the history. I'll tweak that part
of the proposed log message before applying so there is no need to
resend.
Thanks.
>
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
> ---
> Hi!
>
> Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from
> the previous review in the commit message :-)
>
> Thanks!
>
> revision.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/revision.h b/revision.h
> index 71e984c452..87f8d798c2 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -292,7 +292,6 @@ struct rev_info {
> struct string_list *ref_message_ids;
> int add_signoff;
> const char *extra_headers;
> - const char *log_reencode;
> const char *subject_prefix;
> int patch_name_max;
> int no_inline;
next prev parent reply other threads:[~2025-04-22 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 21:31 [GSoC PATCH v2] revision: remove log_reencode field from rev_info Lucas Seiki Oshiro
2025-04-22 22:25 ` Junio C Hamano [this message]
2025-04-25 12:51 ` D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyd33kba.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lucasseikioshiro@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).