From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, karthik nayak <karthik.188@gmail.com>
Subject: Re: [PATCH v2] bundle: remove unneeded code
Date: Thu, 12 Dec 2024 00:07:52 +0900 [thread overview]
Message-ID: <xmqqcyhyi7g7.fsf@gitster.g> (raw)
In-Reply-To: <20241211-fix-bundle-create-race-v2-1-6a18bd07edec@iotcl.com> (Toon Claes's message of "Wed, 11 Dec 2024 10:28:15 +0100")
Toon Claes <toon@iotcl.com> writes:
> - No longer user the term "bottomless bundle" and use "full bundle" and
> "incremental bundle" instead, because they are more commonly used.
Good.
> - To verify the full bundle created upto tag actually contains the tag
> object, add a test to clone from the created bundle.
expecting success of 6020.17 'clone from full bundle upto annotated tag':
git clone --mirror v2.bdl tag-clone.git &&
git -C tag-clone.git show-ref |
make_user_friendly_and_stable_output >actual &&
cat >expect <<-\EOF &&
<TAG-2> refs/tags/v2
EOF
false &&
test_cmp expect actual
Cloning into bare repository 'tag-clone.git'...
Receiving objects: 100% (35/35), done.
Resolving deltas: 100% (6/6), done.
not ok 17 - clone from full bundle upto annotated tag
#
# git clone --mirror v2.bdl tag-clone.git &&
# git -C tag-clone.git show-ref |
# make_user_friendly_and_stable_output >actual &&
# cat >expect <<-\EOF &&
# <TAG-2> refs/tags/v2
# EOF
# false &&
# test_cmp expect actual
#
1..17
What's the "false" doing here?
next prev parent reply other threads:[~2024-12-11 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 9:28 [PATCH v2] bundle: remove unneeded code Toon Claes
2024-12-11 15:07 ` Junio C Hamano [this message]
2024-12-11 20:53 ` Toon Claes
2024-12-12 8:08 ` Junio C Hamano
2024-12-11 20:51 ` [PATCH v3] " Toon Claes
2024-12-12 10:11 ` karthik nayak
2024-12-13 3:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyhyi7g7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).