git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jonas Wunderlich via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Jonas Wunderlich <git@03j.de>
Subject: Re: [PATCH] documentation: camel case of config option, and "no" instead of "false"
Date: Wed, 13 Mar 2024 09:14:05 -0700	[thread overview]
Message-ID: <xmqqcyryds8i.fsf@gitster.g> (raw)
In-Reply-To: <pull.1686.git.git.1710279251901.gitgitgadget@gmail.com> (Jonas Wunderlich via GitGitGadget's message of "Tue, 12 Mar 2024 21:34:11 +0000")

"Jonas Wunderlich via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Jonas Wunderlich <git@03j.de>
>
> The `status.showUntrackedFiles` config option only accepts the values "no",
> "normal" or "all", but not as this part of the man page suggested "false".
>
> Signed-off-by: Jonas Wunderlich <git@03j.de>
> ---
>     documentation: camel case of config option, and "no" instead of "false"

The title does not say what variable was broken, and might be better
to pick one that does so, perhaps

	documentation: status.showUntrackedFiles does not take 'false'

or something.  

The name of the configuration variable does make it sound that it is
a Boolean ("do you want me to show untracked files?") and the code
may want to be updated to do accept any string that we recognise as
a Boolean and take 'false' as "no", take 'true' as "normal", and
treat all other input with the current logic.  But documenting the
long-established behaviour correctly is the right thing to do no
matter what we will do next.

Thanks.  Will apply.

> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1686%2Fjonas-w%2Fpatch-1-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1686/jonas-w/patch-1-v1
> Pull-Request: https://github.com/git/git/pull/1686
>
>  Documentation/git-status.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-status.txt b/Documentation/git-status.txt
> index 4dbb88373bc..b0f36fabfb3 100644
> --- a/Documentation/git-status.txt
> +++ b/Documentation/git-status.txt
> @@ -472,7 +472,7 @@ again, because your configuration may already be caching `git status`
>  results, so it could be faster on subsequent runs.
>  
>  * The `--untracked-files=no` flag or the
> -	`status.showUntrackedfiles=false` config (see above for both):
> +	`status.showUntrackedFiles=no` config (see above for both):
>  	indicate that `git status` should not report untracked
>  	files. This is the fastest option. `git status` will not list
>  	the untracked files, so you need to be careful to remember if
>
> base-commit: 945115026aa63df4ab849ab14a04da31623abece

      reply	other threads:[~2024-03-13 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 21:34 [PATCH] documentation: camel case of config option, and "no" instead of "false" Jonas Wunderlich via GitGitGadget
2024-03-13 16:14 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcyryds8i.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@03j.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).