From: Junio C Hamano <gitster@pobox.com>
To: Vincenzo Mezzela <vincenzo.mezzela@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [GSOC][PATCH v3 1/1] t7301: use test_path_is_(missing|file)
Date: Mon, 04 Mar 2024 13:50:41 -0800 [thread overview]
Message-ID: <xmqqcys9oedq.fsf@gitster.g> (raw)
In-Reply-To: <20240304171732.64457-2-vincenzo.mezzela@gmail.com> (Vincenzo Mezzela's message of "Mon, 4 Mar 2024 18:17:32 +0100")
Vincenzo Mezzela <vincenzo.mezzela@gmail.com> writes:
> Refactor test -f to utilize the corresponding helper functions from
As Eric pointed out to another GSoC applicant in a different thread,
this is not refactoring any code, so saying "refactor" is a bit
misleading.
Replace use of "test -f" with the "test_path_is_file" helper
function ...
> test-lib-functions.sh. These functions perform identical operations
> while enhancing debugging capabilities in case of test failures.
>
> In the context of this file, 'test ! -f' is meant to check if the file
> has been correctly cleaned, thus its usage is replaced with
> 'test_path_is_missing' instead of '! test_path_is_file'.
In other words, the original used "test ! -f" when it meant to say
"test ! -e", and test_path_is_missing would be a correct replacement?
If so that makes sense.
next prev parent reply other threads:[~2024-03-04 21:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 17:22 [GSOC][RFC PATCH 0/1] microproject: use test_path_is_* functions in test scripts Vincenzo Mezzela
2024-02-19 17:22 ` [GSOC][RFC PATCH 1/1] t: t7301-clean-interactive: Use test_path_is_(missing|file) Vincenzo Mezzela
2024-02-26 10:13 ` Christian Couder
2024-02-19 19:36 ` [GSOC][RFC PATCH 0/1] microproject: use test_path_is_* functions in test scripts Eric Sunshine
2024-02-27 16:17 ` [GSOC][PATCH v2 " Vincenzo Mezzela
2024-02-27 16:17 ` [GSOC][PATCH v2 1/1] t7301: use test_path_is_(missing|file) Vincenzo Mezzela
2024-03-04 9:31 ` Patrick Steinhardt
2024-03-04 17:17 ` [GSOC][PATCH v3 0/1] microproject: use test_path_is_* functions in test scripts Vincenzo Mezzela
2024-03-04 17:17 ` [GSOC][PATCH v3 1/1] t7301: use test_path_is_(missing|file) Vincenzo Mezzela
2024-03-04 21:50 ` Junio C Hamano [this message]
2024-03-04 23:53 ` Eric Sunshine
2024-03-10 11:43 ` [GSOC][PATCH v4 0/1] microproject: use test_path_is_* functions in test scripts Vincenzo Mezzela
2024-03-10 11:43 ` [GSOC][PATCH v4 1/1] t7301: use test_path_is_(missing|file) Vincenzo Mezzela
2024-03-11 16:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcys9oedq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=vincenzo.mezzela@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).