From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>,
"Chandra Pratap via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org,
"Chandra Pratap" <chandrapratap376@gmail.com>,
"Chandra Pratap" <chandrapratap3519@gmail.com>
Subject: Re: [PATCH] commit.c: ensure strchrnul() doesn't scan beyond range
Date: Thu, 08 Feb 2024 13:44:48 -0800 [thread overview]
Message-ID: <xmqqcyt6my0f.fsf@gitster.g> (raw)
In-Reply-To: <20240208214137.GB1090198@coredump.intra.peff.net> (Jeff King's message of "Thu, 8 Feb 2024 16:41:37 -0500")
Jeff King <peff@peff.net> writes:
> 1. It is not possible for the buf/len pair we pass to check_nonce() to
> contain a NUL. And thus there is no caller of find_header_mem()
> that can contain an embedded NUL. So switching from strchrnul() to
> just memchr() should be OK there.
Correct.
> 2. That raises the question of whether parse_signed_buffer() has a
> similar walk-too-far problem. ;) The answer is no, because we feed
> it from a strbuf. But it's not a great pattern overall.
True, too.
Thanks.
next prev parent reply other threads:[~2024-02-08 21:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 17:21 [PATCH] commit.c: ensure strchrnul() doesn't scan beyond range Chandra Pratap via GitGitGadget
2024-02-05 19:57 ` René Scharfe
2024-02-06 18:44 ` Junio C Hamano
2024-02-08 1:00 ` Jeff King
2024-02-08 18:31 ` René Scharfe
2024-02-08 19:48 ` Junio C Hamano
2024-02-08 19:52 ` Kyle Lippincott
2024-02-08 21:41 ` Jeff King
2024-02-08 21:44 ` Junio C Hamano [this message]
2024-02-06 1:41 ` Kyle Lippincott
2024-02-07 13:57 ` [PATCH v2] commit.c: ensure find_header_mem() doesn't scan beyond given range Chandra Pratap via GitGitGadget
2024-02-07 17:09 ` René Scharfe
2024-02-07 17:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyt6my0f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chandrapratap3519@gmail.com \
--cc=chandrapratap376@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).