From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] fuzz: fix fuzz test build rules
Date: Fri, 19 Jan 2024 14:46:11 -0800 [thread overview]
Message-ID: <xmqqcytxhrgs.fsf@gitster.g> (raw)
In-Reply-To: <9332e225e44b29be25d10229b05f0b9775b85568.1705700054.git.steadmon@google.com> (Josh Steadmon's message of "Fri, 19 Jan 2024 13:38:12 -0800")
Josh Steadmon <steadmon@google.com> writes:
> @@ -762,7 +763,7 @@ fuzz-objs: $(FUZZ_OBJS)
> # Always build fuzz objects even if not testing, to prevent bit-rot.
> all:: $(FUZZ_OBJS)
So, this is what you referred to in your proposed log message. We
do build objects to prevent bit-rot, but we do not link, so it is
merely half a protection.
> ...
> fuzz-all: $(FUZZ_PROGRAMS)
But there is this target. I wonder if it makes it even better to
update the "always build fuzz objects" one? Given that some folks
may not have the necessary clang toochain for linking, it may
probably be a bit too much, perhaps?
It definitely is an improvement to build them in the CI environment,
like you have in [2/2].
Thanks. Will queue.
next prev parent reply other threads:[~2024-01-19 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 21:38 [PATCH 0/2] Run limited fuzz tests in GitHub CI Josh Steadmon
2024-01-19 21:38 ` [PATCH 1/2] fuzz: fix fuzz test build rules Josh Steadmon
2024-01-19 22:46 ` Junio C Hamano [this message]
2024-03-04 18:57 ` Josh Steadmon
2024-01-19 21:38 ` [PATCH 2/2] ci: build and run minimal fuzzers in GitHub CI Josh Steadmon
2024-01-19 22:28 ` [PATCH 0/2] Run limited fuzz tests " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcytxhrgs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).