From: Junio C Hamano <gitster@pobox.com>
To: Taylor Santiago <taylorsantiago@google.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] Fix the order of consuming unpackLimit config settings.
Date: Tue, 22 Aug 2023 18:55:01 -0700 [thread overview]
Message-ID: <xmqqcyzeh6a2.fsf@gitster.g> (raw)
In-Reply-To: <CAKacvadS8X_nb6Z=yub9eJ54hRYWq4B7CYrWaw=uXBY8dPChYA@mail.gmail.com> (Taylor Santiago's message of "Tue, 22 Aug 2023 06:00:20 -0700")
Taylor Santiago <taylorsantiago@google.com> writes:
> Thank you! How would you like me to proceed? Should I submit the above as a
> v2 of the earlier patch?
There is nothing "above" as you seem to be top posting ;-)
When somebody else helps by supplying an "squashable" patch, often
people are expected to review it and then update their patch(es)
using the given material to produce a v2.
But as I said, the "squashable" one was only about the receive-pack
side; even if you combined it with your original, tests for the
fetch side were still missing, so it was not sufficient for a v2.
As I didn't see your reply message (to which I am responding to)
until now, mostly because it was dropped by the mailing list
(perhaps it was an HTML e-mail from GMail or something???), I've
further worked on the tests to cover the fetch side and sent out a
full version (not a squashable, but just a replacement for the whole
thing). It is archived and viewable at
https://lore.kernel.org/git/xmqqpm3eh7f6.fsf@gitster.g
Part of it is still your original patch, some material in its
proposed commit log message was given by Peff, and the rest was
written by me, so it carries names of three people.
If the result looks acceptable to you, then saying "Yup, that looks
good" would be the simplest answer to give to move things forward.
Thanks.
next prev parent reply other threads:[~2023-08-23 1:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 21:53 [PATCH 0/1] Fix the order of consuming unpackLimit config settings Taylor Santiago
2023-08-17 21:53 ` [PATCH 1/1] " Taylor Santiago
2023-08-21 20:30 ` Jeff King
2023-08-22 1:34 ` Junio C Hamano
2023-08-23 1:30 ` Junio C Hamano
2023-08-23 19:03 ` Jeff King
[not found] ` <CAKacvadS8X_nb6Z=yub9eJ54hRYWq4B7CYrWaw=uXBY8dPChYA@mail.gmail.com>
2023-08-23 1:55 ` Junio C Hamano [this message]
2023-08-23 3:32 ` Taylor Santiago
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyzeh6a2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=taylorsantiago@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).