From: Junio C Hamano <gitster@pobox.com>
To: Wesley Schwengle <wesleys@opperschaap.net>
Cc: git@vger.kernel.org
Subject: Re: [[PATCH v2]] Fix bug when more than one readline instance is used
Date: Thu, 10 Aug 2023 18:01:12 -0700 [thread overview]
Message-ID: <xmqqcyzupf3b.fsf@gitster.g> (raw)
In-Reply-To: <20230810011831.1423208-1-wesleys@opperschaap.net> (Wesley Schwengle's message of "Wed, 9 Aug 2023 21:18:31 -0400")
Wesley Schwengle <wesleys@opperschaap.net> writes:
> diff --git a/git-svn.perl b/git-svn.perl
> index be987e316f..93f6538d61 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> ...
> - if ($@) {
> - $term = new FakeTerm "$@: going non-interactive";
> + $term = $ENV{"GIT_SVN_NOTTY"}
> + ? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT
> + : new Term::ReadLine 'git-svn';
> + };
This line with "};" on it should not be added, I think.
cf. https://github.com/git/git/actions/runs/5827208598/job/15802787783#step:5:74
> + return $term;
> }
> }
git-svn.perl | 1 -
1 file changed, 1 deletion(-)
diff --git a/git-svn.perl b/git-svn.perl
index 93f6538d61..e919c3f172 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -307,7 +307,6 @@ package main;
$term = $ENV{"GIT_SVN_NOTTY"}
? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT
: new Term::ReadLine 'git-svn';
- };
return $term;
}
}
--
2.42.0-rc1
next prev parent reply other threads:[~2023-08-11 1:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 0:39 [PATCH] Fix bug when more than one readline instance is used Wesley Schwengle
2023-08-10 0:49 ` Jeff King
2023-08-10 1:18 ` [[PATCH v2]] " Wesley Schwengle
2023-08-10 14:31 ` Junio C Hamano
2023-08-10 15:14 ` Wesley
2023-08-11 1:01 ` Junio C Hamano [this message]
2023-08-11 1:09 ` Wesley
2023-08-11 5:30 ` Junio C Hamano
2023-08-11 14:51 ` Jeff King
2023-08-11 16:05 ` Junio C Hamano
2023-08-30 22:32 ` [PATCH] git-svn: drop FakeTerm hack Junio C Hamano
2023-08-31 0:13 ` Jeff King
2023-08-31 0:28 ` Junio C Hamano
2023-08-10 1:05 ` [PATCH] Fix bug when more than one readline instance is used Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyzupf3b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=wesleys@opperschaap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).