From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Stephen Manz via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>, Stephen Manz <smanz@alum.mit.edu>
Subject: Re: [PATCH] worktree: teach `add` to accept --reason <string> with --lock
Date: Fri, 09 Jul 2021 08:23:02 -0700 [thread overview]
Message-ID: <xmqqczrr8qax.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQbBPGN+Dcvmy+ZAZeKLpffRrN4-2PNjRHzDHj56axcJg@mail.gmail.com> (Eric Sunshine's message of "Fri, 9 Jul 2021 02:11:34 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> "reasons". That possibility suggests that this particular
> reason-giving option of `git worktree add` ought to be named
> `--lock-reason`, but `git worktree add --lock --lock-reason=<reason>`
> feels clunky and redundant, which is why I was wondering if `git
> worktree --lock[=<reason>]` would be a better (and more convenient)
> UI.
Sure, but
$ git worktree add --lock --reason=why-do-i-want-to-lock \
--frotz --reason=why-do-i-want-to-frotz
would work just fine, no?
next prev parent reply other threads:[~2021-07-09 15:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 5:47 [PATCH] worktree: teach `add` to accept --reason <string> with --lock Stephen Manz via GitGitGadget
2021-07-06 6:19 ` Eric Sunshine
2021-07-06 19:42 ` Junio C Hamano
2021-07-09 6:11 ` Eric Sunshine
2021-07-09 15:23 ` Junio C Hamano [this message]
2021-07-10 7:11 ` Eric Sunshine
2021-07-08 15:50 ` [PATCH v2 0/3] worktree: teach add to accept --reason " Stephen Manz via GitGitGadget
2021-07-08 15:50 ` [PATCH v2 1/3] t2400: remove unneeded `git rev-parse` from '"add" worktree with lock' test Stephen Manz via GitGitGadget
2021-07-08 15:50 ` [PATCH v2 2/3] worktree: default lock string should be marked with `_()` for translation Stephen Manz via GitGitGadget
2021-07-09 6:19 ` Eric Sunshine
2021-07-09 15:58 ` Junio C Hamano
2021-07-08 15:50 ` [PATCH v2 3/3] worktree: teach `add` to accept --reason <string> with --lock Stephen Manz via GitGitGadget
2021-07-09 7:45 ` [PATCH v2 0/3] worktree: teach add to accept --reason " Eric Sunshine
2021-07-09 16:03 ` Junio C Hamano
2021-07-10 7:15 ` Eric Sunshine
2021-07-11 0:27 ` [PATCH v3 " Stephen Manz via GitGitGadget
2021-07-11 0:27 ` [PATCH v3 1/3] t2400: clean up '"add" worktree with lock' test Stephen Manz via GitGitGadget
2021-07-11 0:27 ` [PATCH v3 2/3] worktree: mark lock strings with `_()` for translation Stephen Manz via GitGitGadget
2021-07-11 0:27 ` [PATCH v3 3/3] worktree: teach `add` to accept --reason <string> with --lock Stephen Manz via GitGitGadget
2021-07-13 3:37 ` Eric Sunshine
2021-07-13 3:47 ` [PATCH v3 0/3] worktree: teach add to accept --reason " Eric Sunshine
2021-07-15 2:32 ` [PATCH v4 " Stephen Manz via GitGitGadget
2021-07-15 2:32 ` [PATCH v4 1/3] t2400: clean up '"add" worktree with lock' test Stephen Manz via GitGitGadget
2021-07-15 2:32 ` [PATCH v4 2/3] worktree: mark lock strings with `_()` for translation Stephen Manz via GitGitGadget
2021-07-15 2:32 ` [PATCH v4 3/3] worktree: teach `add` to accept --reason <string> with --lock Stephen Manz via GitGitGadget
2021-07-15 17:17 ` [PATCH v4 0/3] worktree: teach add to accept --reason " Eric Sunshine
2021-07-17 0:14 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczrr8qax.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=smanz@alum.mit.edu \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).