From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
John Lin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, John Lin <johnlinp@gmail.com>
Subject: Re: [PATCH] Recommend "git gc --auto" instead of "git prune"
Date: Mon, 08 Jun 2020 10:34:16 -0700 [thread overview]
Message-ID: <xmqqd069law7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200607204531.GA2313@generichostname> (Denton Liu's message of "Sun, 7 Jun 2020 16:45:31 -0400")
Denton Liu <liu.denton@gmail.com> writes:
>> Correct. When running manually, after noticing the need to do a GC,
>> it is a mental bug to add "--auto" to it, I would think.
>
> Sorry about the confusion, when I was responding to the original
> issue[0], I mistakenly typed the wrong thing. I meant to suggest
> replacing it with `git gc --prune=now`, _not_ `git gc --auto` but I
> guess I had my wires crossed. With this in mind...
>
> The rationale behind this change is that John wanted to add bash
> completions for `git prune`. However, I noted that prune is a plumbing
> command and users should opt to use `git gc` instead. He mentioned that
> sometimes when auto gc runs, it tells the user that they should run
> `git prune` so I suggested (meant to suggest) replacing the command with
> `git gc --prune=now` instead so that users could call the porcelain.
Nice to know. The reasoning behind the change should be available
to those who only look at "git show".
John, if you are to send an updated patch, please make sure you have
a meaningful log message in it.
Thanks.
prev parent reply other threads:[~2020-06-08 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 16:18 [PATCH] Recommend "git gc --auto" instead of "git prune" John Lin via GitGitGadget
2020-06-07 16:25 ` brian m. carlson
2020-06-07 17:10 ` Junio C Hamano
2020-06-07 20:45 ` Denton Liu
2020-06-08 17:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd069law7.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johnlinp@gmail.com \
--cc=liu.denton@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).