From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Oct 2018, #02; Sat, 13)
Date: Sat, 13 Oct 2018 10:03:21 +0900 [thread overview]
Message-ID: <xmqqd0seac9y.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAGZ79kZGEMWpr7aqeqXbC4bkmsCCiW+1pxbEV4T0vfsYG+_3iA@mail.gmail.com> (Stefan Beller's message of "Fri, 12 Oct 2018 12:44:23 -0700")
Stefan Beller <sbeller@google.com> writes:
>> * sb/submodule-recursive-fetch-gets-the-tip (2018-10-11) 9 commits
>> . builtin/fetch: check for submodule updates for non branch fetches
>> . fetch: retry fetching submodules if needed objects were not fetched
>> . submodule: fetch in submodules git directory instead of in worktree
>> . repository: repo_submodule_init to take a submodule struct
>> . submodule.c: do not copy around submodule list
>> . submodule.c: move global changed_submodule_names into fetch submodule struct
>> . submodule.c: sort changed_submodule_names before searching it
>> . submodule.c: fix indentation
>> . sha1-array: provide oid_array_filter
>>
>> "git fetch --recurse-submodules" may not fetch the necessary commit
>> that is bound to the superproject, which is getting corrected.
>>
>> Ejected for now, as it has fallouts in places like t/helper/.
>
> This is the first time I hear about that, I'll look into that.
> The tipmost commit there is also shoddy, I'll redo that.
This is the first time I saw the breakage with this series, but I
would not be suprised, as this was rerolled recently. Who knows
what got changed in this series and in other topics---any new
interaction can arise and that is a normal part of distributed
development.
The xx/sb-submodule-recursive-fetch-gets-the-tip-in-pu branch at
git://github.com/gitster/git.git has a merge of this into 'pu', with
textual conflicts all resolved.
At least t/helper/test-submodule-nested-repo-config.c fails to
build; I didn't check if there are other breakages.
next prev parent reply other threads:[~2018-10-13 1:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 14:53 What's cooking in git.git (Oct 2018, #02; Sat, 13) Junio C Hamano
2018-10-12 15:02 ` Ævar Arnfjörð Bjarmason
2018-10-12 19:44 ` Stefan Beller
2018-10-12 23:37 ` Stefan Beller
2018-10-13 1:03 ` Junio C Hamano [this message]
2018-10-15 17:32 ` Stefan Beller
2018-10-16 21:20 ` Josh Steadmon
2018-10-16 23:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd0seac9y.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).