From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Han-Wen Nienhuys <hanwen@google.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] Document git config getter return value.
Date: Mon, 30 Jul 2018 13:03:04 -0700 [thread overview]
Message-ID: <xmqqd0v4fq4n.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cQkFHtOw=gJ1Y5vjQipeAgRon214tUs09o3k3LkevHu4g@mail.gmail.com> (Eric Sunshine's message of "Mon, 30 Jul 2018 14:48:00 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Mon, Jul 30, 2018 at 8:26 AM Han-Wen Nienhuys <hanwen@google.com> wrote:
>> ---
>> config.h | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> Missing sign-off.
Besides, the patch is corrupt in that it miscounts both preimage and
postimage lines and claims it applies to a 11-line block even though
there are only 10 lines there.
next prev parent reply other threads:[~2018-07-30 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 12:26 [PATCH 1/2] Document git config getter return value Han-Wen Nienhuys
2018-07-30 12:26 ` [PATCH 2/2] Highlight keywords in remote sideband output Han-Wen Nienhuys
2018-07-30 18:48 ` [PATCH 1/2] Document git config getter return value Eric Sunshine
2018-07-30 20:03 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-31 17:36 [PATCH 0/2 v3] Highlight keywords in remote sideband output Han-Wen Nienhuys
2018-07-31 17:36 ` [PATCH 1/2] Document git config getter return value Han-Wen Nienhuys
2018-08-01 8:24 ` Eric Sunshine
2018-07-30 12:18 Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd0v4fq4n.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).