From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Apr 2018, #02; Tue, 17)
Date: Thu, 19 Apr 2018 05:56:52 +0900 [thread overview]
Message-ID: <xmqqd0ywi67f.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <287d6c83-2c7e-3138-def4-fee5d9cb9e48@gmail.com> (Derrick Stolee's message of "Wed, 18 Apr 2018 08:50:10 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> I'm sorry that my second message was terse. My response to v1 [1] was
>
>> I looked through these patches and only found one set of whitespace
>> >
> errors. Compiles and tests fine on my machine. > > Reviewed-by:
> Derrick Stolee <dstolee@microsoft.com> So, I pulled the code, went
> through it patch-by-patch, and saw that the transformations were made
> using the established pattern. The second review was to chime in that
> my v1 comments had been addressed. Thanks, -Stolee
> [1]
> https://public-inbox.org/git/6c319100-df47-3b8d-8661-24e4643ada09@gmail.com/
Thanks.
next prev parent reply other threads:[~2018-04-18 20:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 6:07 What's cooking in git.git (Apr 2018, #02; Tue, 17) Junio C Hamano
2018-04-17 14:04 ` Eric Sunshine
2018-04-17 18:05 ` Stefan Beller
2018-04-18 1:04 ` Junio C Hamano
2018-04-18 12:50 ` Derrick Stolee
2018-04-18 20:56 ` Junio C Hamano [this message]
2018-04-18 13:09 ` Jonathan Tan
2018-04-18 20:57 ` Junio C Hamano
2018-04-18 15:17 ` Christian Hesse
2018-04-18 21:00 ` Junio C Hamano
2018-04-18 19:39 ` Elijah Newren
2018-04-18 21:04 ` Junio C Hamano
2018-04-19 11:52 ` Sergey Organov
2018-04-20 22:18 ` js/rebase-recreate-merges, was " Johannes Schindelin
2018-04-22 20:17 ` Taylor Blau
2018-04-22 23:33 ` Junio C Hamano
2018-04-22 23:38 ` Taylor Blau
2018-04-23 13:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd0ywi67f.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).