From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] show-branch: show all local heads when only giving one rev along --topics
Date: Mon, 30 Mar 2015 15:24:26 -0700 [thread overview]
Message-ID: <xmqqd23qw2cl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1427753543-19680-1-git-send-email-mh@glandium.org> (Mike Hommey's message of "Tue, 31 Mar 2015 07:12:23 +0900")
Mike Hommey <mh@glandium.org> writes:
> (Maybe --topics should always require one rev on the command
> line?)
That sounds line a good thing to do.
> - else if (all_heads + all_remotes)
> - snarf_refs(all_heads, all_remotes);
> else {
> while (0 < ac) {
> append_one_rev(*av);
> ac--; av++;
> }
> + if (all_heads + all_remotes)
> + snarf_refs(all_heads, all_remotes);
Hmmmmmm. Is this safe and will not cause problems by possibly
duplicated refnames that came from the command line and the ones
that came from for-each-ref iteration? I am not saying the change
is problematic; it is just I haven't looked at this code for a long
time that the existing machinery is already designed to tolerate
duplicated input.
Thanks.
next prev parent reply other threads:[~2015-03-30 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 22:12 [PATCH] show-branch: show all local heads when only giving one rev along --topics Mike Hommey
2015-03-30 22:24 ` Junio C Hamano [this message]
2015-03-30 22:34 ` Junio C Hamano
2015-03-30 22:37 ` Mike Hommey
-- strict thread matches above, loose matches on Subject: below --
2015-03-16 8:38 Mike Hommey
2015-03-16 23:50 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd23qw2cl.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).