From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0B5A31194C for ; Mon, 6 Apr 2026 21:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510226; cv=none; b=B3Z9JBl0zmtOry6bxCivkb2ch57RPj9TxMuvrnh6zyUiYclElnQAgqmqkR946bArGZeKseNjhtBPOQIXENGt/DxtbpWg4QwSh+dmFEew3fiITAlgJW5denqqeTzyC74kDTdvONtNNgOPn/0CZumIJdsbJipc3Je7teeavsoluhs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510226; c=relaxed/simple; bh=asUSt2kFT1YzF9BvHLHpgef/kg+P2fu7UkF42bOHNIY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=pwrgD20ry/VmuL3QVLHx5qQUw1HRdQ07XsNyRutakfQ20t1VADd/5YRjO5SO17p1nqWHplHoSJ0GH4Q17/1/qdB6BkJG4+5fCXYILRAsWGOI3JIZkiKRm7xElCjNrmpm5co57sA+dZ3lJCSx3AJrNHwr5E+fqBiXWWV6+bqdyn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=VP4CvD3f; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=qP7F1GHo; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="VP4CvD3f"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="qP7F1GHo" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 25D65140025D; Mon, 6 Apr 2026 17:17:04 -0400 (EDT) Received: from phl-frontend-02 ([10.202.2.161]) by phl-compute-06.internal (MEProxy); Mon, 06 Apr 2026 17:17:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1775510224; x=1775596624; bh=wFI1hj7NEt lF8IA8EhPadz9sChRuzbNk5g3mZ3JPNQw=; b=VP4CvD3fpLMNBeoLiCRU1KPiJp T9fe9wDez1qKiClfHYR7znxq2QWKxEhbF4RGQ3YSCC4L+G8OnMsS51nDLcZhtdgU bbJNgLJePMzqxlMwbP/poxveSty5K4bo2ajScs06/WvDk5lzIMs+9N0QJiEeGes/ RESIb86EdYVUU7ROtGrTFyDLKcv4qbm/VmZHMTys6/m8dmbVTV/I2YuN+ZHXFyRG ivxHRQ5dwR1/LOG+tFjADe0FeWM1MZHFNCj4ao1SeUJgmYOJ5MIjulhvhA72WfRk 6fOzbiGWQeu7HXCtThZzvte9iq8LVV0ilRSNgTdyx7bkBsJNNF8zvYcpyITg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1775510224; x=1775596624; bh=wFI1hj7NEtlF8IA8EhPadz9sChRuzbNk5g3 mZ3JPNQw=; b=qP7F1GHopPFrpXUZvq0O39kFaSDi5s4+nTw0D+FlhULBiZJnRtz q8/uMDV2exGkpw6ltXVbTGnz6dA4x7jOnmc7UTiTsA0TTHW3yQ3k0ewtGudnt93B IR96jM7yATu7Ru/Om44QccNmoXCxTbyv/37fsPmUmK78+M+jbeCQL+a1C5jXAX5k 6ZHkvj+dpNx/xk+O/6ZtIfylWkmWeCGECP77R8lHd2/e9QQ/KFm7Ot295hfa+Mnd IlgqvOz+dMQmLIDLdOnvbHDTKkmDEhK3h1pp5ZLce1ZI9gxDxoTtHDnu04orLQF2 3AQWnegjvFZD9aczIdGR14c0gTkcc2dIyiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddukeektdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfgfgggtsehttdfotddtredtnecuhfhrohhmpefluhhnihhoucev ucfjrghmrghnohcuoehgihhtshhtvghrsehpohgsohigrdgtohhmqeenucggtffrrghtth gvrhhnpefgteejgeduveeuteeiudfhhfeguddtjefhjedvffelteelhfdtveejueehudff ueenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepghhithhsthgvrhesphhosghogidrtghomhdp nhgspghrtghpthhtohepledpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhorh gvnhiiohdrphgvghhorhgrrhhivddttddvsehgmhgrihhlrdgtohhmpdhrtghpthhtohep tggrthesmhgrlhhonhdruggvvhdprhgtphhtthhopehgihhtsehvghgvrhdrkhgvrhhnvg hlrdhorhhgpdhrtghpthhtohepshhtohhlvggvsehgmhgrihhlrdgtohhmpdhrtghpthht ohepphhssehpkhhsrdhimhdprhgtphhtthhopehmvgesthhtrgihlhhorhhrrdgtohhmpd hrtghpthhtohepnhgvfihrvghnsehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhunhhs hhhinhgvsehsuhhnshhhihhnvggtohdrtghomhdprhgtphhtthhopehgihhtshhtvghrse hpohgsohigrdgtohhm X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Apr 2026 17:17:03 -0400 (EDT) From: Junio C Hamano To: Lorenzo Pegorari Cc: Tian Yuchen , git@vger.kernel.org, Derrick Stolee , Patrick Steinhardt , Taylor Blau , Elijah Newren , Eric Sunshine Subject: Re: [GSoC PATCH v3 2/5] pack-write: add helper to fill promisor file after repack In-Reply-To: (Lorenzo Pegorari's message of "Mon, 6 Apr 2026 20:40:49 +0200") References: <3cd15429194c763727fbfd5981ba38c1dc2cc907.1775431990.git.lorenzo.pegorari2002@gmail.com> Date: Mon, 06 Apr 2026 14:17:02 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Lorenzo Pegorari writes: > On Tue, Apr 07, 2026 at 01:22:16AM +0800, Tian Yuchen wrote: >> Hi, >> >> On 4/6/26 08:24, LorenzoPegorari wrote: >> >> > + while (strbuf_getline(&line, source) != EOF) { >> > + struct strbuf **parts; >> > + struct object_id oid; >> > + >> > + /* Split line into , and