From: Junio C Hamano <gitster@pobox.com>
To: "Abhijeetsingh Meena via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Abhijeetsingh Meena <abhijeetsingh.github@gmail.com>,
Abhijeetsingh Meena <abhijeet040403@gmail.com>
Subject: Re: [PATCH] dir.h: remove duplicate forward declaration of struct repository
Date: Tue, 11 Mar 2025 15:13:04 -0700 [thread overview]
Message-ID: <xmqqecz32p3j.fsf@gitster.g> (raw)
In-Reply-To: <pull.1879.git.1741705175922.gitgitgadget@gmail.com> (Abhijeetsingh Meena via GitGitGadget's message of "Tue, 11 Mar 2025 14:59:35 +0000")
"Abhijeetsingh Meena via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Abhijeetsingh Meena <abhijeet040403@gmail.com>
>
> The `struct repository;` forward declaration appears twice in `dir.h`:
> once at line 10 and again at line 46. This duplication is unnecessary
> and likely unintentional.
>
> Removing the second declaration has no impact on compilation, as verified
> by a clean build.
>
> Signed-off-by: Abhijeetsingh Meena <abhijeet040403@gmail.com>
> ---
Thanks. Will apply.
> dir.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/dir.h b/dir.h
> index a3a2f00f5d9..e659c47ad77 100644
> --- a/dir.h
> +++ b/dir.h
> @@ -43,7 +43,6 @@ struct repository;
> *
> */
>
> -struct repository;
>
> struct dir_entry {
> unsigned int len;
>
> base-commit: ef8ce8f3d4344fd3af049c17eeba5cd20d98b69f
prev parent reply other threads:[~2025-03-11 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 14:59 [PATCH] dir.h: remove duplicate forward declaration of struct repository Abhijeetsingh Meena via GitGitGadget
2025-03-11 22:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqecz32p3j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=abhijeet040403@gmail.com \
--cc=abhijeetsingh.github@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).