From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Aaron Plattner <aplattner@nvidia.com>,
git@vger.kernel.org, Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [PATCH v2] credential: clear expired c->credential, unify secret clearing
Date: Thu, 06 Jun 2024 08:13:46 -0700 [thread overview]
Message-ID: <xmqqed9ap0id.fsf@gitster.g> (raw)
In-Reply-To: <20240606081054.GC658959@coredump.intra.peff.net> (Jeff King's message of "Thu, 6 Jun 2024 04:10:54 -0400")
Jeff King <peff@peff.net> writes:
> items that reject() is clearing is the best one. So I'd just as soon
> leave it as a weird internal detail for now, rather than codifying it in
> a function.
>
> I dunno. I guess it is the same lines of code in either spot, but
> somehow sticking it in a clear_response() helper seems like an
> endorsement that the author knew what they were doing. ;)
True. It probably belongs to too premature abstraction. Thanks.
prev parent reply other threads:[~2024-06-06 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 19:29 [PATCH v2] credential: clear expired c->credential, unify secret clearing Aaron Plattner
2024-06-04 20:51 ` Junio C Hamano
2024-06-04 21:21 ` brian m. carlson
2024-06-04 22:04 ` Junio C Hamano
2024-06-04 22:19 ` Aaron Plattner
2024-06-04 22:28 ` Rahul Rameshbabu
2024-06-05 5:12 ` Junio C Hamano
2024-06-05 8:57 ` Jeff King
2024-06-05 16:45 ` Aaron Plattner
2024-06-06 8:08 ` Jeff King
2024-06-05 17:06 ` Junio C Hamano
2024-06-06 8:10 ` Jeff King
2024-06-06 15:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqed9ap0id.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aplattner@nvidia.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).