From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Scott Leggett <scott@sl.id.au>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] commit-graph: retain commit slab when closing NULL commit_graph
Date: Fri, 05 Jan 2024 11:56:15 -0800 [thread overview]
Message-ID: <xmqqedevo8ps.fsf@gitster.g> (raw)
In-Reply-To: <20240105054142.GA2035092@coredump.intra.peff.net> (Jeff King's message of "Fri, 5 Jan 2024 00:41:42 -0500")
Jeff King <peff@peff.net> writes:
> This fixes a regression introduced in ac6d45d11f (commit-graph: move
> slab-clearing to close_commit_graph(), 2023-10-03), in which running:
> ...
> So it happens to work out. But it still seems questionable to me that we
> would clear a global slab (which might still be in use) when closing the
> commit graph. This clearing comes from 957ba814bf (commit-graph: when
> closing the graph, also release the slab, 2021-09-08), and was fixing a
> case where we really did need it to be closed (and in that case we
> presumably call close_object_store() more directly).
Wow, that is nasty.
But anyway, thanks for your usual "3 pages of explanation for 2
lines of change". The patch does look the best fix in the meantime.
prev parent reply other threads:[~2024-01-05 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 5:41 [PATCH] commit-graph: retain commit slab when closing NULL commit_graph Jeff King
2024-01-05 17:07 ` Taylor Blau
2024-01-10 11:39 ` Jeff King
2024-01-10 16:38 ` Junio C Hamano
2024-01-11 7:53 ` Jeff King
2024-01-11 18:35 ` Junio C Hamano
2024-01-05 19:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedevo8ps.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=scott@sl.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).