From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Karthik Nayak <karthik.188@gmail.com>,
Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH 2/2] ref-filter: support filtering of operational refs
Date: Wed, 03 Jan 2024 09:59:13 -0800 [thread overview]
Message-ID: <xmqqedey9u32.fsf@gitster.g> (raw)
In-Reply-To: <ZZWbMekL2URby0qV@tanuki> (Patrick Steinhardt's message of "Wed, 3 Jan 2024 18:36:49 +0100")
Patrick Steinhardt <ps@pks.im> writes:
>> I think we should tighten things up over time. First by teaching
>> the ref backend that anything that is not a pseudoref, HEAD or a
>> proper ref (one item of whose definition is "lives under refs/
>> hierarchy) should not resolve_ref() successfully. That should
>> correctly fail things like
>>
>> $ git rev-parse worktrees/$name/bisect/bad
>> $ git update-ref foo/bar HEAD
> ...
> Yeah, agreed, that's something we should do. I do wonder whether this
> will break existing usecases, but in any case I'd rather consider it an
> accident that it is possible to write (and read) such refs in the first
> place.
Unfortunately, the worktrees/$name/refs/bisect/bad and its friends
are documented in "git worktree" and the refs.c layer is aware of
the "main-worktree/" and "worktrees/" hierarchy, so while I still
think it is a good long-term direction to make it impossible to
create random refs like "foo/bar" and "resf/heads/master" via the
commands like "git update-ref", we cannot limit ourselves only to
"refs/" hierarchy.
next prev parent reply other threads:[~2024-01-03 17:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 17:07 [RFC 0/2] Initial changes to support printing all refs Karthik Nayak
2023-12-21 17:07 ` [PATCH 1/2] refs: introduce the `refs_single_ref` function Karthik Nayak
2023-12-21 17:07 ` [PATCH 2/2] ref-filter: support filtering of operational refs Karthik Nayak
2023-12-21 20:40 ` Junio C Hamano
2023-12-22 14:05 ` Karthik Nayak
2023-12-26 17:01 ` Junio C Hamano
2024-01-02 15:18 ` Karthik Nayak
2024-01-02 16:49 ` Junio C Hamano
2024-01-02 18:47 ` Taylor Blau
2024-01-03 8:52 ` Patrick Steinhardt
2024-01-03 10:22 ` Karthik Nayak
2024-01-03 14:38 ` Junio C Hamano
2024-01-03 15:50 ` Patrick Steinhardt
2024-01-03 16:02 ` Junio C Hamano
2024-01-03 16:17 ` Patrick Steinhardt
2024-01-03 17:21 ` Junio C Hamano
2024-01-03 17:36 ` Patrick Steinhardt
2024-01-03 17:59 ` Junio C Hamano [this message]
2024-01-03 18:01 ` Patrick Steinhardt
2024-01-04 11:31 ` Karthik Nayak
2024-01-04 23:59 ` Junio C Hamano
2024-01-03 15:45 ` Taylor Blau
2024-01-03 15:52 ` Patrick Steinhardt
2024-01-03 17:00 ` Taylor Blau
2023-12-28 10:34 ` Patrick Steinhardt
2024-01-02 15:23 ` Karthik Nayak
2024-01-02 18:49 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedey9u32.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).