git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: <rsbecker@nexbridge.com>
Cc: <git@vger.kernel.org>
Subject: Re: [BUG] Git 2.42.0-rc2 t1092.57 script error
Date: Fri, 18 Aug 2023 12:05:16 -0700	[thread overview]
Message-ID: <xmqqedk0uq6r.fsf@gitster.g> (raw)
In-Reply-To: <018601d9d1fc$2049ede0$60ddc9a0$@nexbridge.com> (rsbecker@nexbridge.com's message of "Fri, 18 Aug 2023 13:47:52 -0400")

<rsbecker@nexbridge.com> writes:

> I'm getting the following error when running t1092.57 in Git 2.42.0-rc2
> on NonStop ia64:
>
> + ensure_not_expanded status
> test_region[8]: test: argument expected
> grep: ensure_full_index: No such file or directory
> error: last command exited with $?=1
> not ok 57 - sparse-index is not expanded
>
> Any suggestions?

Sorry for not coming up with anything concrete.

"ensure_not_expanded status" should be running as its second step

	test_region ! index ensure_full_index trace2.txt

Which should do this:

    test_region () {
            local expect_exit=0
            if test "$1" = "!"
            then
                    expect_exit=1
                    shift
            fi

            grep -e	'"region_enter".*"category":"'"$1"'","label":"'"$2"\" "$3"
            exitcode=$?

            if test $exitcode != $expect_exit
            then


As "grep" complains that ensure_full_index is not a file, when the
command runs there the file name is "$3".

So it appears to me that the first 

	test "$1" = "!"

is not firing and failing to set expect_exit to 1 and shift the "!"
out of $@.  Why?  I dunno.  Perhaps your shell has quirks around
"local"?  I dunno.



  reply	other threads:[~2023-08-18 19:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 17:47 [BUG] Git 2.42.0-rc2 t1092.57 script error rsbecker
2023-08-18 19:05 ` Junio C Hamano [this message]
2023-08-18 19:38   ` rsbecker
2023-08-18 21:27     ` Junio C Hamano
2023-08-18 21:53       ` rsbecker
     [not found]         ` <202308182302.37IN2tgW2384518@secure.elehost.com>
2023-08-18 23:25           ` rsbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedk0uq6r.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).