From: Junio C Hamano <gitster@pobox.com>
To: Josip Sokcevic <sokcevic@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff-lib: honor override_submodule_config flag bit
Date: Wed, 14 Jun 2023 00:06:50 -0700 [thread overview]
Message-ID: <xmqqedmezfn9.fsf@gitster.g> (raw)
In-Reply-To: 20230614041626.2979067-2-sokcevic@google.com
Josip Sokcevic <sokcevic@google.com> writes:
> When `diff.ignoreSubmodules = all` is set and a submodule commit is
> manually staged, `git-commit` should accept it.
What does "it" refer to in this sentence? Does "accept"ing mean
"Even if the configuration tells us to ignore all submodules, the
command should record the commit with updated submodule"? Or does
it mean "as the configuration tells us to ignore all submodules, the
command should honor that wish and the command should record the
commit with the same commit at the submodule path as the parent
commit, ignoring the manual addition"? The sentence needs to be
rewritten to clarify so that readers won't have to ask the above
question.
Everything else I wrote in my draft review I notice was adequately
covered by Eric's review, so I've removed them from this message.
Thanks.
next prev parent reply other threads:[~2023-06-14 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 4:16 [PATCH] diff-lib: honor override_submodule_config flag bit Josip Sokcevic
2023-06-14 4:56 ` Eric Sunshine
2023-06-14 7:06 ` Junio C Hamano [this message]
2023-06-14 18:45 ` Josip Sokcevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedmezfn9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sokcevic@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).