From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>,
"Diomidis Spinellis" <dds@aueb.gr>,
"Eric Sunshine" <sunshine@sunshineco.com>,
demerphq <demerphq@gmail.com>,
"Mario Grgic" <mario_grgic@hotmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH] userdiff: support regexec(3) with multi-byte support
Date: Fri, 07 Apr 2023 09:02:44 -0700 [thread overview]
Message-ID: <xmqqedovlly3.fsf@gitster.g> (raw)
In-Reply-To: <CALnO6CDgs+of5KCRRwpmzEoHcqZ4udbHVhNrd63q4fFh_5TwHg@mail.gmail.com> (D. Ben Knoble's message of "Fri, 7 Apr 2023 10:41:07 -0400")
"D. Ben Knoble" <ben.knoble@gmail.com> writes:
> On Thu, Apr 6, 2023 at 4:19 PM René Scharfe <l.s.r@web.de> wrote:
>>
>> Since 1819ad327b (grep: fix multibyte regex handling under macOS,
>> 2022-08-26) we use the system library for all regular expression
>> matching on macOS, not just for git grep. It supports multi-byte
>> strings and rejects invalid multi-byte characters.
>> ...
>> Reported-by: D. Ben Knoble <ben.knoble@gmail.com>
>> Reported-by: Eric Sunshine <sunshine@sunshineco.com>
>> Helped-by: Junio C Hamano <gitster@pobox.com>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>
> I tested the patch locally on top of ae73b2c8f1 and it solved my
> problem. Seems like there's still some further discussion, though.
Thanks very much for reporting and testing. Also, thanks all for
working on this solution.
Will queue.
next prev parent reply other threads:[~2023-04-07 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 22:55 regex compilation error with --color-words Eric Sunshine
2023-03-30 7:55 ` Diomidis Spinellis
2023-03-31 20:44 ` René Scharfe
2023-04-02 9:44 ` René Scharfe
2023-04-03 16:29 ` Junio C Hamano
2023-04-03 19:32 ` René Scharfe
2023-04-06 20:19 ` [PATCH] userdiff: support regexec(3) with multi-byte support René Scharfe
2023-04-06 22:35 ` Johannes Sixt
2023-04-07 7:49 ` René Scharfe
2023-04-07 10:56 ` Johannes Sixt
2023-04-07 14:41 ` D. Ben Knoble
2023-04-07 16:02 ` Junio C Hamano [this message]
2023-04-07 17:23 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedovlly3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=ben.knoble@gmail.com \
--cc=dds@aueb.gr \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=mario_grgic@hotmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).