From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH] repack: respect --keep-pack with geometric repack
Date: Fri, 20 May 2022 15:12:32 -0700 [thread overview]
Message-ID: <xmqqee0ng8fj.fsf@gitster.g> (raw)
In-Reply-To: <xmqqr14oey2a.fsf@gitster.g> (Junio C. Hamano's message of "Fri, 20 May 2022 13:41:49 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>>> + /*
>>> + * The pack may be kept via the --keep-pack option;
>>> + * check 'existing_kept_packs' to determine whether to
>>> + * ignore it.
>>> + */
>
> OK. So there are two classes of packs we want to exclude from the
> geometry repacking. Those that already have .pack_keep bit set, and
> those that are _are_ newly making into kept packs that do not yet
> have .pack_keep bit set. Makes sense.
And with another topic in-flight combined, we have the third class
that we would want to exclude here, i.e. the ones that are "cruft".
(Noticed while rebuilding 'seen').
next prev parent reply other threads:[~2022-05-20 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 16:36 [PATCH] repack: respect --keep-pack with geometric repack Victoria Dye via GitGitGadget
2022-05-20 17:00 ` Taylor Blau
2022-05-20 17:27 ` Victoria Dye
2022-05-20 19:05 ` Taylor Blau
2022-05-20 20:41 ` Junio C Hamano
2022-05-20 22:12 ` Junio C Hamano [this message]
2022-05-20 22:20 ` Taylor Blau
2022-05-20 23:26 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqee0ng8fj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).