From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Tom Miller <jackerran@gmail.com>, git@vger.kernel.org
Subject: Re: Propose promoting 'contrib/rerere-train.sh' to command
Date: Sat, 21 Dec 2019 15:52:53 -0800 [thread overview]
Message-ID: <xmqqeewx6xt6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191221193110.GB3339249@coredump.intra.peff.net> (Jeff King's message of "Sat, 21 Dec 2019 14:31:10 -0500")
Jeff King <peff@peff.net> writes:
> The situations where I need rerere-train don't come up often, but when
> they do, it has always worked easily and without hiccups for me. So
> perhaps there are lurking gotchas that Junio might know about, but AFAIK
> the quality is high enough for it to be part of normal Git.
I actually suspect that rewriting has a high chance of initially
degrading the quality, so we should take a two step approach if we
really want it as part of the core distribution. As to the UI, I
think "git rerere train a..b" would be a good one, but if the
scripted version is of high quality (I haven't looked at it for a
long time---even though I used it for a couple of times a year in
recent years), perhaps we can add it as "git-rerere--train"
subcommand that is spawned from "builtin/rerere.c" for the first
cut?
> I'd suggest converting it to C and making it a sub-command of rerere
> (i.e., "git rerere train a..b") rather than a separate command.
next prev parent reply other threads:[~2019-12-21 23:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 2:17 Propose promoting 'contrib/rerere-train.sh' to command Tom Miller
2019-12-21 17:00 ` Philip Oakley
2019-12-21 17:37 ` Philip Oakley
2019-12-21 19:31 ` Jeff King
2019-12-21 23:52 ` Junio C Hamano [this message]
2019-12-22 7:58 ` Jeff King
2019-12-22 13:14 ` Tom Miller
2020-01-01 22:06 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeewx6xt6.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jackerran@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).