From: Junio C Hamano <gitster@pobox.com>
To: Alexander Blesius <alexander+git@blesius.eu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: fix typos in man pages
Date: Mon, 18 Mar 2019 14:42:32 +0900 [thread overview]
Message-ID: <xmqqef744u2f.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <6e00f5fc-13a3-a9b9-d964-f787ae194a73@blesius.eu> (Alexander Blesius's message of "Sat, 16 Mar 2019 11:34:39 +0100")
Alexander Blesius <alexander+git@blesius.eu> writes:
> Signed-off-by: Alexander Blesius <alexander+git@blesius.eu>
> ---
> Documentation/git-worktree.txt | 4 ++--
> Documentation/gitattributes.txt | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt
> index cb86318f3e..fa5ec7a5dc 100644
> --- a/Documentation/git-worktree.txt
> +++ b/Documentation/git-worktree.txt
> @@ -213,8 +213,8 @@ refs of one working tree from another.
> In general, all pseudo refs are per working tree and all refs starting
> with "refs/" are shared. Pseudo refs are ones like HEAD which are
> -directly under GIT_DIR instead of inside GIT_DIR/refs. There are one
> -exception to this: refs inside refs/bisect and refs/worktree is not
> +directly under GIT_DIR instead of inside GIT_DIR/refs. There is one
> +exception to this: refs inside refs/bisect and refs/worktree are not
> shared.
Perhaps bisect is one and worktree is the other, and that made them
two things (plural) in the author's mind. But the single exception
is about these two hierarchies, so "is" is correct ;-)
> Refs that are per working tree can still be accessed from another
> diff --git a/Documentation/gitattributes.txt
> b/Documentation/gitattributes.txt
> index 9b41f81c06..908d9a3009 100644
> --- a/Documentation/gitattributes.txt
> +++ b/Documentation/gitattributes.txt
> @@ -314,8 +314,8 @@ stored as UTF-8 internally. A client without
> `working-tree-encoding`
> support will checkout `foo.ps1` as UTF-8 encoded file. This will
> typically cause trouble for the users of this file.
> +
> -If a Git client, that does not support the `working-tree-encoding`
> -attribute, adds a new file `bar.ps1`, then `bar.ps1` will be
> +If a Git client that does not support the `working-tree-encoding`
> +attribute adds a new file `bar.ps1`, then `bar.ps1` will be
Or s/that/which/. I am not sure which one gives us a cleaner
result.
If a new file `bar.ps1` is added by a Git client that does not
understand `working-tree-encoding` attribute, then ...
is how I may write it, though. I dunno. Let's take yours at least
for now and let others complain if they care deeply about it.
> stored "as-is" internally (in this example probably as UTF-16).
> A client with `working-tree-encoding` support will interpret the
> internal contents as UTF-8 and try to convert it to UTF-16 on checkout.
Thanks.
next prev parent reply other threads:[~2019-03-18 5:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 10:34 [PATCH] doc: fix typos in man pages Alexander Blesius
2019-03-18 5:42 ` Junio C Hamano [this message]
2019-03-18 8:54 ` Alexander Blesius
2019-03-18 7:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqef744u2f.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=alexander+git@blesius.eu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).