From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Steve Hoelzer <shoelzer@gmail.com>,
gitgitgadget@gmail.com, git <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues
Date: Sat, 03 Nov 2018 09:49:48 +0900 [thread overview]
Message-ID: <xmqqefc3nfwz.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqin1fngdx.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Sat, 03 Nov 2018 09:39:38 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> Johannes Sixt <j6t@kdbg.org> writes:
>
>>> Yep, correct on all counts. I'm in favor of changing the commit message to
>>> only say that this patch removes Warning C28159.
>>
>> How about this fixup instead?
>
> Isn't that already in 'next'? I didn't check, though.
Well, it turnsout that I already prepared one but not pushed it out
yet. I'll eject this topic and rebuild the integration branches,
and wait until Dscho says something, to avoid having to redo the
integration cycle again.
Thanks.
next prev parent reply other threads:[~2018-11-03 0:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 21:11 [PATCH 0/1] Make compat/poll safer on Windows Johannes Schindelin via GitGitGadget
2018-10-31 21:11 ` [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues Steve Hoelzer via GitGitGadget
2018-11-01 10:21 ` Johannes Sixt
2018-11-02 14:47 ` Steve Hoelzer
2018-11-02 16:43 ` Johannes Sixt
2018-11-02 17:18 ` Steve Hoelzer
2018-11-03 0:39 ` Junio C Hamano
2018-11-03 0:49 ` Junio C Hamano [this message]
2018-11-03 8:14 ` Carlo Arenas
2018-11-03 14:05 ` Johannes Sixt
2018-11-04 23:26 ` Junio C Hamano
2018-11-04 23:44 ` Randall S. Becker
2018-11-05 3:33 ` Eric Sunshine
2018-11-05 4:02 ` Junio C Hamano
2018-11-05 7:01 ` Johannes Sixt
2018-11-05 20:28 ` Johannes Sixt
2018-11-05 22:05 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefc3nfwz.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=shoelzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).