From: Junio C Hamano <gitster@pobox.com>
To: Max Kirillov <max@max630.net>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>,
Florian Manschwetus <manschwetus@cs-software-gmbh.de>,
Chris Packham <judge.packham@gmail.com>,
Konstantin Khomoutov <kostix+git@007spb.ru>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] http-backend: respect CONTENT_LENGTH for receive-pack
Date: Mon, 04 Jun 2018 13:31:58 +0900 [thread overview]
Message-ID: <xmqqefhn5g01.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180602212749.21324-3-max@max630.net> (Max Kirillov's message of "Sun, 3 Jun 2018 00:27:49 +0300")
Max Kirillov <max@max630.net> writes:
> +static void pipe_fixed_length(const char *prog_name, int out, size_t req_len)
> +{
> + unsigned char buf[8192];
> + size_t remaining_len = req_len;
> +
> + while (remaining_len > 0) {
> + size_t chunk_length = remaining_len > sizeof(buf) ? sizeof(buf) : remaining_len;
> + size_t n = xread(0, buf, chunk_length);
> + if (n < 0)
> + die_errno("Reading request failed");
n that is of type size_t is unsigned and cannot be negative here.
next prev parent reply other threads:[~2018-06-04 4:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 21:27 [PATCH v7 0/2] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-02 21:27 ` [PATCH v7 1/2] " Max Kirillov
2018-06-04 3:44 ` Jeff King
2018-06-02 21:27 ` [PATCH v7 2/2] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-06-04 4:31 ` Junio C Hamano [this message]
2018-06-04 17:06 ` Max Kirillov
2018-06-05 2:30 ` Ramsay Jones
2018-06-04 4:44 ` Jeff King
2018-06-04 22:18 ` Max Kirillov
2018-06-10 15:06 ` Max Kirillov
2018-06-11 9:18 ` Jeff King
2018-06-11 9:24 ` Jeff King
2018-06-10 15:07 ` Max Kirillov
2018-06-11 8:59 ` Jeff King
2018-06-10 15:05 ` [PATCH v8 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-10 15:05 ` [PATCH v8 1/3] http-backend: cleanup writing to child process Max Kirillov
2018-06-10 15:05 ` [PATCH v8 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-06-10 15:05 ` [PATCH v8 3/3] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-07-25 12:14 ` SZEDER Gábor
2018-07-25 14:51 ` Max Kirillov
2018-07-25 18:41 ` SZEDER Gábor
2018-07-26 4:37 ` Max Kirillov
2018-07-27 3:48 ` [PATCH v9 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-07-27 3:48 ` [PATCH v9 1/3] http-backend: cleanup writing to child process Max Kirillov
2018-07-27 3:48 ` [PATCH v9 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-08-04 6:34 ` Duy Nguyen
2018-08-04 11:28 ` Max Kirillov
2018-08-04 17:20 ` Junio C Hamano
2018-07-27 3:48 ` [PATCH v9 3/3] http-backend: respect CONTENT_LENGTH for receive-pack Max Kirillov
2018-07-27 3:50 ` [PATCH v9 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875 Max Kirillov
2018-07-27 17:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefhn5g01.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
--cc=kostix+git@007spb.ru \
--cc=manschwetus@cs-software-gmbh.de \
--cc=max@max630.net \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).